[
https://issues.apache.org/jira/browse/CASSANDRA-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12741958#action_12741958
]
Bill de hOra commented on CASSANDRA-358:
----------------------------------------
{quote}the explanation is simple but how does taking care of state three double
the existing code size? {quote}
That would be my preference for organizing clumps of code using Compose Method,
in this case to make what the main does function explicit. No big deal. I'll
submit a functional patch anon.
{quote}no underscore_ in variables is preferred. if a class is mixed cleanup
should convert to no-underscores.{quote}
np, I thought that was the preferred idiom.
{quote}
avoid splitting methods up that are not reusable or perform a simple
expression. if a block of code is used in only one place, prefer leaving it
inline (use whitespace to denote logical blocks, and comments if necessary).
obviously there are gray areas but methods like "notFound" and "applyAddColumn"
are definitely over the line.
{quote}
Sure; in this code base there is code whose design intent isn't clear,
initMetadata being an example ;)
> SystemTable.initMetadata throws an NPE when called twice
> --------------------------------------------------------
>
> Key: CASSANDRA-358
> URL: https://issues.apache.org/jira/browse/CASSANDRA-358
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jeff Hodges
> Attachments: 358-4.patch, 358-5.patch
>
>
> While this is not the expected use case of it, SystemTable.initMetadata
> throws an NPE when called twice in the same process. The error points to
> tokenColumn being null even through cf is not at line 111.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
