[ 
https://issues.apache.org/jira/browse/CASSANDRA-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742960#action_12742960
 ] 

Jonathan Ellis commented on CASSANDRA-362:
------------------------------------------

01 and 02 are renaming and cleanup.

03 has fixes for 4 separate bugs that colluded to break this. :)

+            tableKeysCachedFractions_.put("system", 0.01);

this is required to flush now, so we need to generate it for the system table 
(keyspace).

-                    /* TODO: Remove this to not process Hints */

for some reason FB decided not to replay writes to the system tables.  the 
comment indicates that this was an optimization for hinted handoff, but if 
there isn't much hinted handoff data, then replaying isn't a Big Deal, and if 
there _is_ a lot then you probably don't want to throw it away.

this was biting us here since we moved the token/generation info into the 
system table instead of a special-cased file.

+        QueryFilter filter = new IdentityQueryFilter(LOCATION_KEY, new 
QueryPath(LOCATION_CF));

the old query only fetched generation.  this is the easiest way to fetch the 
whole CF.

+        return ColumnFamily.create(getTableName(), getColumnFamilyName());

old code was broken (passing null in several places).  not sure why; didn't 
investigate too closely since the new code is the more straightforward solution 
anyway.

> SystemTable is not persisted across reboots
> -------------------------------------------
>
>                 Key: CASSANDRA-362
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-362
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.4
>            Reporter: Sammy Yu
>            Assignee: Sammy Yu
>             Fix For: 0.4
>
>         Attachments: 0001-CASSANDRA-362-rename-underscores-away.txt, 
> 0002-rename-getInitialToken-to-getToken-it-doesn-t-actuall.txt, 
> 0003-fix-incompletely-configured-system-table-and-query-for.txt
>
>
> If you set InititalToken to "" and restart cassandra it should generate a 
> initialtoken and store it in the SystemTable so that next time it is not 
> regenerated.  However, this is not the case as a new inititaltoken is 
> generated every time.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to