[ 
https://issues.apache.org/jira/browse/CASSANDRA-386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746233#action_12746233
 ] 

Jun Rao commented on CASSANDRA-386:
-----------------------------------

The last test in SliceQueryFilter.collectReducedColumns() doesn't seem quite 
right. It seems that the test should be the following:
            // but we need to add all non-gc-able columns to the result for 
read repair
            if ( ( !column.isMarkedForDelete()
                   && (!container.isMarkedForDelete() || 
column.mostRecentChangeAt() > container.getMarkedForDeleteAt())
                 )    // this is to get all included columns
                 || (column.isMarkedForDelete() && 
column.getLocalDeletionTime() > gcBefore) // this is to get all deleted, but 
not garbage-collected columns
              )



> CompareWith="LongType" CF mis-applies tombstones
> ------------------------------------------------
>
>                 Key: CASSANDRA-386
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-386
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.4
>            Reporter: Evan Weaver
>         Attachments: 386-v2.patch, 386.patch
>
>
> jbellis: what is "mis applying?"
> evn: later inserts have no effect
> jbellis: so you do a remove with timestamp X, then timestamp X + 1 has no 
> effect?
> evn: yeah
> jbellis: did you try a similar test w/ a ascii comparewith?
> evn: well the identical test passes w/ TimeUUIDType
>       <Keyspace Name="MultiblogLong">      
>         <KeysCachedFraction>0.01</KeysCachedFraction>
>         <ColumnFamily CompareWith="LongType" Name="Blogs"/>
>         <ColumnFamily CompareWith="LongType" Name="Comments"/>
>       </Keyspace>
> $ ruby test/cassandra_test.rb -n test_get_first_long_column
> insert at 1250740275826063
> .
> 1 tests, 3 assertions, 0 failures, 0 errors
> $ ruby test/cassandra_test.rb -n test_get_first_long_column
> remove at 1250740278998607
> insert at 1250740279011751
> F
>   1) Failure:
> test_get_first_long_column(CassandraTest) [test/cassandra_test.rb:70]:
> <{<Cassandra::Long#13703350 time: Tue Jul 14 00:20:16 -0400 1970, usecs: 0, 
> jitter: 3626>=>
>   "I like this cat"}> expected but was
> <{}>.
> 1 tests, 1 assertions, 1 failures, 0 errors

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to