[ 
https://issues.apache.org/jira/browse/CASSANDRA-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747984#action_12747984
 ] 

Jonathan Ellis commented on CASSANDRA-389:
------------------------------------------

+1 on the general approach and cleanup, thanks!

Can you redo to follow http://wiki.apache.org/cassandra/CodeStyle?

In particular the Descriptor final fields should be public and not underscored. 
 Avoid mutating the temporary-ness in favor of creating a new Descriptor.  And 
use split() instead of tokenizing; just counting the fields will show whether 
it's a "legacy" name.

> SSTable Versioning
> ------------------
>
>                 Key: CASSANDRA-389
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-389
>             Project: Cassandra
>          Issue Type: Improvement
>    Affects Versions: 0.4
>            Reporter: Chris Goffinet
>            Assignee: Stu Hood
>            Priority: Minor
>             Fix For: 0.4
>
>         Attachments: CASSANDRA-389.diff
>
>
> As we continue to make changes to the on-disk format of SSTables, I propose 
> we start versioning. The easiest way without breaking backwards compatibility 
> is to store the version in the filename. This would allow us to figure out 
> the version without looking at the SSTable data. After speaking to Jonathan 
> here is the proposed example:
> <CF>-<ID>-<VERSION>-<DATA|INDEX|FILTER>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to