[ 
https://issues.apache.org/jira/browse/CASSANDRA-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771015#action_12771015
 ] 

Jonathan Ellis commented on CASSANDRA-350:
------------------------------------------

 - won't there be conditions w/ this version where outOfBounds will be hit in 
the while loop, so getNextBlock returns true, so it will be called again, doing 
another seek?
 - i think we can safely bail before seeking if the first outOfBounds test is 
true.  attaching patch (to apply on top of yours)

> optimize away unnecessary range scans
> -------------------------------------
>
>                 Key: CASSANDRA-350
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-350
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: Gary Dusbabek
>             Fix For: 0.5
>
>         Attachments: 350-diff-to-v3.patch, cassandra-350-v2-tests.patch, 
> cassandra-350-v2.patch, cassandra-350-v3.patch, cassandra-350.patch
>
>
> Even when a the columns exist for a given key, they usually won't exist in 
> all the sstable segments.  So avoiding the scan when the column index shows 
> we can, will be a win.
> This is what the todo in SSTableSliceIterator is about:
>         // TODO push finishColumn down here too, so we can tell when we're 
> done and optimize away the slice when the index + start/stop shows there's 
> nothing to scan for

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to