[
https://issues.apache.org/jira/browse/CASSANDRA-558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jaakko Laine updated CASSANDRA-558:
-----------------------------------
Attachment: 0004-two-trivial-changes.patch
Here are a couple of comments (some of them truly trivial). I'll see if I have
time to do a patch later.
(1) insert and insertBlocking have big chunk of almost identical code. Perhaps
it would be good to have a separate this part to a separate method.
(2) HintedHandoffManager.deliverHintsToEndpoint calls sendMessage with null
middle argument (table name). This will cause assertion error later in
table.get. It would seem variable tableName (which is already present there)
will do the trick.
(3) Hinted endpoint might be local. We could perhaps use local write for that
too. This is a very rare case, though, so perhaps not worth the trouble.
(4) WriteResponseResolver can be removed?
(5) HintedHandoffManager.deleteEndPoint doesn't seem to work. Hinted endpoints
remain in the list and hints are delivered every time a node, for which we have
hints, comes online.
(6) A log entry about liveNodes being less than blockFor would be nice?
(7) See patch for two trivial changes
> optimize local writes
> ---------------------
>
> Key: CASSANDRA-558
> URL: https://issues.apache.org/jira/browse/CASSANDRA-558
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.5
>
> Attachments:
> 0001-CASSANDRA-558-make-local-insert-skip-MessagingServic.txt,
> 0002-add-WriteResponseHandler-combining-the-important-parts.txt,
> 0003-rename.txt, 0004-two-trivial-changes.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
