[
https://issues.apache.org/jira/browse/CASSANDRA-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12783815#action_12783815
]
Jonathan Ellis commented on CASSANDRA-535:
------------------------------------------
first patch: looking much better. i think we can simplify still further by not
calling initMetadata at all for client mode. (the only reason would be to get
a Generation, and we can always just use system.currentTimeMillis for that;
generation is for determining what app state takes precedence and client mode
won't use app state.)
adding an assert to gossip app state creation making sure we are not in client
mode would be good.
the main() method should be moved to contrib as an example, and commented-out
code cleaned out.
second patch: why create a new Timer on gossip stop? there is a Timer.stop
method, so i must be missing something here.
> Support remote clients via Java API
> -----------------------------------
>
> Key: CASSANDRA-535
> URL: https://issues.apache.org/jira/browse/CASSANDRA-535
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: T Jake Luciani
> Assignee: Gary Dusbabek
> Fix For: 0.9
>
> Attachments: 535-v1.diff, 535-v2-reentrant-fixes-and-tests.patch,
> 535-v2.patch
>
>
> Cassandra should support Java based clients without requiring the overhead of
> thrift serialization.
> To support this, a java client should be able to join the gossip pool but
> provide no tokens of its own (so it accepts no writes).
> The way this can be done is add a new startup routine to StorageService
> called startGossip() that would only initialize itself enough to get access
> to gossip.
> I don't think its quite this simple though since cassandra code assumes there
> is at least one local token in places.
> Also, all StorageProxy methods used for thrift service should be made public
> StorageProxy.getKeyRange() is not public.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
