[ 
https://issues.apache.org/jira/browse/CASSANDRA-597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786162#action_12786162
 ] 

Jonathan Ellis commented on CASSANDRA-597:
------------------------------------------

Oops, I thought "heartbeat" and "generation" were the same thing.  They're not, 
hence my confusion. :)

Applied original patch.

I still note that although notifyFailureDetector and applyHeartBeatStateLocally 
treat the generation/version tuple correctly, switching to a compareTo would be 
clearer.

Perhaps it would be clearest of all to have a single long version instead of 2 
ints, where the high order bits are current generation?

> remove "heartbeat" from HeartBeatState
> --------------------------------------
>
>                 Key: CASSANDRA-597
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-597
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.5
>            Reporter: Jaakko Laine
>            Priority: Minor
>             Fix For: 0.5
>
>         Attachments: 597.patch
>
>
> "heartbeat" in HeartBeatState does not seem to be used for anything, perhaps 
> an old relic => remove.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to