[
https://issues.apache.org/jira/browse/CASSANDRA-631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789748#action_12789748
]
Jonathan Ellis commented on CASSANDRA-631:
------------------------------------------
applied -tiny to 0.5 and trunk, good catch.
-big removes private from a bunch of variables for no reason, so left that part
out, but applied the generics fixes to trunk (although fixing generics only to
add in an ObjectUtils call requiring a cast seems a little schizophrenic to me;
saving a 2-element array allocation in get_range_slice is like picking up a
teaspoon of sand from the seashore :)
> possible NPE in StorageProxy?
> -----------------------------
>
> Key: CASSANDRA-631
> URL: https://issues.apache.org/jira/browse/CASSANDRA-631
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Environment: all
> Reporter: gabriele renzi
> Fix For: 0.5, 0.9
>
> Attachments: CASSANDRA-631-big.patch, CASSANDRA-631-tiny.patch
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> insert() in StorageProxy contains a logging statement that refers to a
> possibly un-initialized variable
> {{{
> logger.debug("insert writing key " + rm.key() + " to " +
> unhintedMessage.getMessageId() + "@" + hintedTarget + " for " + target);
> }}}
> this could happen if getHintedEndpointMap(rm.key(), naturalEndpoints) returns
> only elements for which target.equals(hintedTarget) returns false, which
> seems possible to me.
> Looking at the code I get the feeling the reference should probably be to
> 'hintedMessage', instead of "unhintedMessage", if not so an
> assert statement could be appropriate
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
