[
https://issues.apache.org/jira/browse/CASSANDRA-688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801033#action_12801033
]
Nate McCall edited comment on CASSANDRA-688 at 1/16/10 12:36 AM:
-----------------------------------------------------------------
Great addition! Just a nitpicky documentation issue - the changes in
storage-conf.xml are worded to suggest that only values between 0-1 are
acceptable for RowsCached whereas in the one example the value is 1000 and 10%
in another. Values between 0-1, integers and percentages all appear to work as
expected.
Perhaps changing the comment like so might make it more clear:
~ The optional RowsCached attribute specifies the number of rows
~ whose entire contents we cache in memory, either as a fixed number
~ of rows, a percent of rows in the ColumnFamily, or as with key caching,
~ a value between 0 and 1. Do not use this on ColumnFamilies with
~ large rows, or ColumnFamilies with high write:read ratios.
~ The default 0 disables it entirely.
Thanks again, this is going to be a huge help.
was (Author: zznate):
Great addition! Just a nitpicky documentation issue - the changes in
storage-conf.xml are worded to suggest that only values between 0-1 are
acceptable for RowsCached whereas in the one example the value is 1000 and 10%
in another. Values between 0-1, integers and percentages all appear to work as
expected.
Perhaps changing the comment like so might make it more clear:
> cache refinements
> -----------------
>
> Key: CASSANDRA-688
> URL: https://issues.apache.org/jira/browse/CASSANDRA-688
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.9
>
> Attachments: 0001-move-cache-classes-to-cassandra.cache-package.txt,
> 0002-extract-InstrumentingCache-from-jmx-code.txt,
> 0003-add-JMXAggregatingCache-to-present-all-the-SSTR-keycac.txt,
> 0004-change-RowsCachedFraction-option-to-RowsCached-specifi.txt,
> 0005-allow-setting-row-cache-size-from-jmx.txt,
> 0006-approximate-capacity-setting-in-key-cache-by-adjusting.txt
>
>
> (continued from CASSANDRA-678)
> - instrument keycache in a way that doesn't make performance suck
> - add Ryan's suggestion of absolute row count config option
> - adjust cache size live
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
