[
https://issues.apache.org/jira/browse/CASSANDRA-620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802839#action_12802839
]
Jaakko Laine commented on CASSANDRA-620:
----------------------------------------
a few initial comments:
- Isn't onFinish called too soon? It should be called only after all tables
have been transferred. I think the easiest would be to have "pending" in
unbootstrap record ranges per table, and when it is completely empty, call
onFinish.
- returning immediately if rangesMM is empty is no longer valid as we're doing
this on table basis. Due to different replication factor, some tables might
need data transfer and some others not.
- pending ranges are still calculated on table basis. This might be a lot of
waste (if we have 10 tables with same strategy, pending ranges will be
calculated 9 times unnecessarily every time a node moves). Of course we may go
with this and optimize later.
> Add per-keyspace replication factor (possibly even replication strategy)
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-620
> URL: https://issues.apache.org/jira/browse/CASSANDRA-620
> Project: Cassandra
> Issue Type: New Feature
> Reporter: Jonathan Ellis
> Assignee: Gary Dusbabek
> Fix For: 0.6
>
> Attachments:
> 0001-push-replication-factor-and-strategy-into-table-exce.patch,
> 0002-cleaned-up-as-much-as-possible-before-dealing-with-r.patch,
> 0003-push-table-names-into-streaming-expose-TMD-in-ARS.patch,
> 0004-fix-non-compiling-tests.patch,
> 0005-introduce-table-into-pending-ranges-code.patch,
> 0006-added-additional-testing-keyspace.patch,
> 0007-modify-TestRingCache-to-make-it-easier-to-test-speci.patch,
> 0008-push-endpoint-snitch-into-keyspace-configuration.patch,
> 0009-make-TMD-private-in-ARS.patch,
> 0010-fix-problems-with-bootstrapping.patch,
> 0011-remove-replicas-from-ARS.patch,
> 0012-ensure-that-unbootstrap-calls-onFinish-after-tables-.patch,
> v1-patches.tgz
>
>
> (but partitioner may only be cluster-wide, still)
> not 100% sure this makes sense but it would allow maintaining system metadata
> in a replicated-across-entire-cluster keyspace (without ugly special casing),
> as well as making Cassandra more flexible as a shared resource for multiple
> apps
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
