[ 
https://issues.apache.org/jira/browse/CASSANDRA-764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12830179#action_12830179
 ] 

Ted Zlatanov commented on CASSANDRA-764:
----------------------------------------

This is why I asked for advice.  "look at the code" showed me several ways to 
do the task.

I see BitSetSerializer used and the bitmasks are most similar to a BitSet so I 
thought it made sense to approach it similarly.  ObjectSerializer simply 
ensures we won't have to write ListSerializer, etc. and in fact 
BitSetSerializer can be reduced to ObjectSerializer<BitSet>.

I also see ColumnSerializer but considering the purpose (bitmasks are not 
supposed to be large or many; if they are then we can revisit this) I thought 
serializing through a String made sense.  If you're suggesting to approach it 
as with ColumnSerializer, that is, to serialize the count and then the byte[] 
objects individually, I can do that too.

Does the SliceFromReadCommand.toString() look OK at least?  Or should I encode 
it more efficiently for space?

Thanks for your help.

> bitmasks applied to SliceRange
> ------------------------------
>
>                 Key: CASSANDRA-764
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-764
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>            Reporter: Ted Zlatanov
>            Priority: Minor
>         Attachments: 001-CASSANDRA-764-bitmasksparameter.patch, 
> 002-CASSANDRA-764-bitmaskserialization.patch
>
>
> Add bitmasks (OR of an array of ANDs) to the SliceRange.  Make them optional.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to