[ 
https://issues.apache.org/jira/browse/CASSANDRA-763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12830302#action_12830302
 ] 

Stu Hood commented on CASSANDRA-763:
------------------------------------

 * Are we trying not to break network compatibility in 0.6? This changes 
RangeSliceCommand
 * I'm worried that since the AbstractBounds class doesn't implement any 
methods, we are basically using the subclasses as boolean values: ('is the 
start included?' == x instanceof Bounds). To make the subclasses worthwhile, we 
need to see a path toward actually encapsulating the intersection logic in 
them: for instance, StorageProxy.restrictBounds should be implemented in terms 
of an intersection between two AbstractBounds objects.

In general, this looks like an improvement, so if we can see a way in the 
future to encapsulate more logic in bounds, I'd be fine with giving it a +1.

> getRangeSlice returns keys from outside the desired range
> ---------------------------------------------------------
>
>                 Key: CASSANDRA-763
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-763
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>             Fix For: 0.6
>
>         Attachments: 0001-add-Range.intersectsWith.txt, 
> 0002-have-RangeSliceCommand-take-Range-or-Bounds-client-bou.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to