[ 
https://issues.apache.org/jira/browse/CASSANDRA-829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838327#action_12838327
 ] 

Hudson commented on CASSANDRA-829:
----------------------------------

Integrated in Cassandra #365 (See 
[http://hudson.zones.apache.org/hudson/job/Cassandra/365/])
    make CompactionExecutor and KeyPosition classes static.  patch by gabriele 
renzi; reviewed by jbellis for 


> inner classes may be static
> ---------------------------
>
>                 Key: CASSANDRA-829
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-829
>             Project: Cassandra
>          Issue Type: Improvement
>    Affects Versions: 0.6
>            Reporter: gabriele renzi
>            Assignee: gabriele renzi
>            Priority: Trivial
>             Fix For: 0.7
>
>         Attachments: CASSANDRA-829.patch
>
>
> the two referenced classes SSTable.KeyPosition and 
> Compactionmanager.CompactionExceutor do not use the outer instances' 
> references and thus can be made static which may save one OOP  per instance.
> The change is a no brainer, but FWIW all tests still pass :)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to