[ 
https://issues.apache.org/jira/browse/CASSANDRA-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841040#action_12841040
 ] 

Jonathan Ellis commented on CASSANDRA-835:
------------------------------------------

This would be more interesting if it refactored existing code to use the new 
methods.

> ThriftGlue should have KeyRange, Mutation, and Deletion creation helper 
> methods to make life easier for users
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-835
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-835
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>            Reporter: Ted Zlatanov
>            Priority: Minor
>         Attachments: 0001-CASSANDRA-835.patch
>
>
> ThriftGlue doesn't have any helper methods for KeyRange, Mutation, and 
> Deletion.  Those should be provided since we can expect API users to need 
> them.
> I propose:
> Mutation createMutation(Deletion d)
> Mutation createMutation(Column c)
> Mutation createMutation(SuperColumn c)
> Deletion createDeletion(byte[] supercolumnName)
> Deletion createDeletion(SlicePredicate predicate)
> KeyRange createKeyRange_Key(String startKey, String endKey)
> KeyRange createKeyRange_Token(String startToken, String endToken)
> I don't know if it's useful to mix keys and tokens in the key range.
> The patch is trivial so let me know if I should put it together.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to