[
https://issues.apache.org/jira/browse/CASSANDRA-845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12842119#action_12842119
]
Jonathan Ellis commented on CASSANDRA-845:
------------------------------------------
+ private static void updateStatus(Priority priority, String msg)
Maybe we should just have it log all these at INFO?
- if (logger.isDebugEnabled())
- logger.debug("Beginning transfer process to " + target + " for
ranges " + StringUtils.join(ranges, ", "));
+ logger.debug("Beginning transfer process to " + target + " for ranges
" + StringUtils.join(ranges, ", "));
was this supposed to turn into updateStatus?
+ StreamingService.instance.setStatus(StreamingService.NOTHING);
can you make these go through updateStatus and just skip the log if it's
nothing?
- if (logger.isDebugEnabled())
- logger.debug("Stream context metadata " +
StringUtils.join(pendingFiles, ", " + " " + sstables.size() + " sstables."));
-
+ updateStatus(Priority.DEBUG, "Stream context metadata " +
StringUtils.join(pendingFiles, ", " + " " + sstables.size() + " sstables."));
let's leave those as just a debug log
logger.info("Waiting for transfer to " + target + " to complete");
+ StreamingService.instance.setStatus("Waiting for transfer to " +
target + " to complete");
should be updateStatus?
+ if (s == null)
+ s = NOTHING;
let's just assert != null instead
we should do a final updateStatus(NOTHING) to reset at the end of transferRanges
> nothing appearing to happen during bootstrap while waiting for anticompaction
> is still confusing
> ------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-845
> URL: https://issues.apache.org/jira/browse/CASSANDRA-845
> Project: Cassandra
> Issue Type: Wish
> Reporter: Jonathan Ellis
> Assignee: Gary Dusbabek
> Priority: Minor
> Fix For: 0.6
>
> Attachments: v1-0001-CASSANDRA-845-add-status-property-for-streams.txt
>
>
> As seen on the recent ML thread
> Can we turn one or more of the .debug statements in StreamOut into a JMX
> notification?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
