[ 
https://issues.apache.org/jira/browse/CASSANDRA-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12842179#action_12842179
 ] 

Eric Evans commented on CASSANDRA-852:
--------------------------------------

Hey Roger, this looks pretty good. I do have a few nits though.

* there seems to be a number of missing imports from CliMain
* watch out for our coding conventions 
(http://wiki.apache.org/cassandra/CodeStyle) in particular, we put opening 
braces on their own line.
* username seems to pair better w/ password as an option name than user does I 
think
* some of the error messages need some work, (i.e. "You are not authorized 
accessing this keyspace on the cassandra node.").

> add login to cli
> ----------------
>
>                 Key: CASSANDRA-852
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-852
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Tools
>    Affects Versions: 0.6
>            Reporter: Jonathan Ellis
>            Assignee: Eric Evans
>            Priority: Minor
>             Fix For: 0.6
>
>         Attachments: CASSANDRA-852.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to