[
https://issues.apache.org/jira/browse/CASSANDRA-625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12842848#action_12842848
]
Gary Dusbabek commented on CASSANDRA-625:
-----------------------------------------
Gabriele, does slf4j add any performance benefit to cassandra, or improve the
logging in a dramatic way? I'm just trying to understand the motivation for
such a change. To me "because thrift uses slf4j" is not compelling enough. :)
> Migrate to slf4j from log4j in cassandra code
> ---------------------------------------------
>
> Key: CASSANDRA-625
> URL: https://issues.apache.org/jira/browse/CASSANDRA-625
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.6
> Environment: all
> Reporter: gabriele renzi
> Priority: Minor
> Fix For: 0.6
>
> Attachments: CASSANDRA-625.patch
>
>
> currently code generated from thrift uses slf4j while cassandra uses raw
> log4j.
> There are various level in which this can be changed:
> * simply switch log4j loggers with slf4j logger (done in patch)
> * replacing log4j-isms (e.g. string concatenation+isFooEnabled in all code
> paths) with slf4j-isms (marker string + additional arguments)
> * remove code that is already available for lsf4j (LogUtils.java, I believe
> is unnecessary)
> I am posting this as a reminder, I have a half baked patch locally but it
> needs more work
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
