[
https://issues.apache.org/jira/browse/CASSANDRA-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12844497#action_12844497
]
Gary Dusbabek commented on CASSANDRA-847:
-----------------------------------------
I'm not comfortable with these changes as they stand. From the perspective of
a reviewer, they are daunting enough. Add to that the number of changes, and I
think we're looking at 2-3 weeks of an unstable trunk while the kinks are
worked out, which will hamper other features.
I realize that this issue is just a part of CASSANDRA-16, but I think this
issue should be broken into several pieces as well: 1) decide on the API we
want to end up with, meld it in or have it replace what we have, 2) alter
SSTable read/write, 3) alter compaction process. Yeah, this basically
corresponds with what Jonathan outlined, but I think it is sensible.
> Make the reading half of compactions memory-efficient
> -----------------------------------------------------
>
> Key: CASSANDRA-847
> URL: https://issues.apache.org/jira/browse/CASSANDRA-847
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Stu Hood
> Priority: Critical
> Fix For: 0.7
>
> Attachments:
> 0001-Add-structures-that-were-important-to-the-SSTableSca.patch,
> 0002-Implement-most-of-the-new-SSTableScanner-interface.patch,
> 0003-Rename-RowIndexedReader-specific-test.patch,
> 0004-Improve-Scanner-tests-and-separate-SuperCF-handling-.patch,
> 0005-Add-Scanner-interface-and-a-Filtered-implementation-.patch,
> 0006-Add-support-for-compaction-of-super-CFs-and-some-tes.patch,
> 0007-Remove-ColumnKey-bloom-filter-maintenance.patch,
> 0008-Make-Scanner-extend-Iterator-again.patch,
> 0009-Make-CompactionIterator-a-ReducingIterator-subclass-.patch,
> 0010-Alternative-to-ReducingIterator-that-can-return-mult.patch
>
>
> This issue is the next on the road to finally fixing CASSANDRA-16. To make
> compactions memory efficient, we have to be able to perform the compaction
> process on the smallest possible chunks that might intersect and contend
> one-another, meaning that we need a better abstraction for reading from
> SSTables.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
