Re: Testing row cache feature in trunk: write should put record in cache

[Weijun Li]

Just tried to make quick change to enable it but it didn't work out :-(

               ColumnFamily cachedRow = cfs.getRawCachedRow(mutation.key());

                // What I modified
                if( cachedRow == null ) {
                    cfs.cacheRow(mutation.key());
                    cachedRow = cfs.getRawCachedRow(mutation.key());
                }

                if (cachedRow != null)
                    cachedRow.addAll(columnFamily);

How can I open a ticket for you to make the change (enable row cache write
through with an option)?

Thanks,
-Weijun

On Tue, Feb 16, 2010 at 5:20 PM, Jonathan Ellis <jbel...@gmail.com> wrote:

> On Tue, Feb 16, 2010 at 7:17 PM, Jonathan Ellis <jbel...@gmail.com> wrote:
> > On Tue, Feb 16, 2010 at 7:11 PM, Weijun Li <weiju...@gmail.com> wrote:
> >> Just started to play with the row cache feature in trunk: it seems to be
> >> working fine so far except that for RowsCached parameter you need to
> specify
> >> number of rows rather than a percentage (e.g., "20%" doesn't work).
> >
> > 20% works, but it's 20% of the rows at server startup.  So on a fresh
> > start that is zero.
> >
> > Maybe we should just get rid of the % feature...
>
> (Actually, it shouldn't be hard to update this on flush, if you want
> to open a ticket.)
>