Branch: refs/heads/master
  Home:   https://github.com/castleproject/Core
  Commit: 212d4956544b96f7d23cdef101a83f13f44adb84
      
https://github.com/castleproject/Core/commit/212d4956544b96f7d23cdef101a83f13f44adb84
  Author: Jean-Claude Viau <[email protected]>
  Date:   2013-05-17 (Fri, 17 May 2013)

  Changed paths:
    M src/Castle.Core/DynamicProxy/ProxyGenerator.cs

  Log Message:
  -----------
  Fixed Proxy of COM class issue, reference count incremented

Calls to Marshal.GetIUnknownForObject and Marshal.QueryInterface
increment the reference count but the code was not decrementing it. This
could cause major leak since the COM object would not be
destroyed/released (reference count never reaching 0).

As stated in MSDN documentation for both method: "Always use
Marshal.Release to decrement the reference count once you have finished
with the pointer."

TEST: break in atlcom.h (InternalAddRef, InteralRelease) to ensure the
reference count is valid.

NOTE : this problem appeared after commit to fix DYNPROXY-186, before
the code related to COM was not executed.


  Commit: 6f10659a682378390af021715e85e357f258b43d
      
https://github.com/castleproject/Core/commit/6f10659a682378390af021715e85e357f258b43d
  Author: Krzysztof Koźmic <[email protected]>
  Date:   2013-05-17 (Fri, 17 May 2013)

  Changed paths:
    M src/Castle.Core/DynamicProxy/ProxyGenerator.cs

  Log Message:
  -----------
  Merge pull request #26 from jcviau/master

Fixed proxy of COM class issue, reference count incremented


Compare: 
https://github.com/castleproject/Core/compare/2a0204ac2ec3...6f10659a6823

-- 
You received this message because you are subscribed to the Google Groups 
"Castle Project Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/castle-project-commits?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to