Your patch is rejected: please provide xml comment to public members
not meant to be exposed:
///<remarks>This API supports your applicative framework
infrastructure and is not intended to be used directly from your
code.</remarks>
as well as some fancy attributes
[DoNotUse,Internal,CodeSmell]
;)
On Dec 11, 7:26 am, "Ayende Rahien" <[EMAIL PROTECTED]> wrote:
> Check the comment on this.If you wrote a windsor facility, I am willing to
> assume that you can handle a rename.
> Or, I can give the user their money back
>
> On Thu, Dec 11, 2008 at 1:22 AM, hammett <[EMAIL PROTECTED]> wrote:
>
> > 1-800-DONTUSEOSS
> > :-p
>
> > On Wed, Dec 10, 2008 at 10:08 PM, Ayende Rahien <[EMAIL PROTECTED]> wrote:
> > > Yes, it is.
> > > I am waiting for the user that would complain about it :-)
> > > On Thu, Dec 11, 2008 at 12:56 AM, hammett <[EMAIL PROTECTED]> wrote:
>
> > >> Breaking changes? :-)
>
> > >> On Wed, Dec 10, 2008 at 9:18 PM, <[EMAIL PROTECTED]>
> > wrote:
>
> > >> > User: ayende
> > >> > Date: 2008/12/10 10:18 PM
>
> > >> > Modified:
> > >> > /trunk/InversionOfControl/Castle.Windsor/
> > >> > IWindsorContainer.cs, WindsorContainer.cs
>
> > >> > Log:
> > >> > Renaming two methods to better match what they are doing
>
> > >> > File Changes:
>
> > >> > Directory: /trunk/InversionOfControl/Castle.Windsor/
> > >> > ====================================================
>
> > >> > File [modified]: IWindsorContainer.cs
> > >> > Delta lines: +2 -2
> > >> > ===================================================================
>
> > >> > --- trunk/InversionOfControl/Castle.Windsor/WindsorContainer.cs
> > >> > 2008-12-11 05:12:02 UTC (rev 5441)
> > >> > +++ trunk/InversionOfControl/Castle.Windsor/WindsorContainer.cs
> > >> > 2008-12-11 05:18:40 UTC (rev 5442)
> > >> > @@ -478,7 +478,7 @@
> > >> > /// <typeparam name="I"></typeparam>
> > >> > /// <typeparam name="T"></typeparam>
> > >> > /// <param name="extendedProperties"></param>
> > >> > - public IWindsorContainer AddComponentLifeStyle<I,
> > >> > T>(IDictionary extendedProperties) where T : class
> > >> > + public IWindsorContainer AddComponentProperties<I,
> > >> > T>(IDictionary extendedProperties) where T : class
> > >> > {
> > >> > Type t = typeof(T);
> > >> > AddComponentWithProperties(t.FullName,
> > typeof(I),
> > >> > t, extendedProperties);
> > >> > @@ -494,7 +494,7 @@
> > >> > /// <typeparam name="T"></typeparam>
> > >> > /// <param name="key"></param>
> > >> > /// <param name="extendedProperties"></param>
> > >> > - public IWindsorContainer AddComponentLifeStyle<I,
> > >> > T>(string key, IDictionary extendedProperties) where T : class
> > >> > + public IWindsorContainer AddComponentProperties<I,
> > >> > T>(string key, IDictionary extendedProperties) where T : class
> > >> > {
> > >> > AddComponentWithProperties(key, typeof(I),
> > >> > typeof(T), extendedProperties);
>
> > >> > File [modified]: WindsorContainer.cs
> > >> > Delta lines: +0 -0
> > >> > ===================================================================
>
> > >> --
> > >> Cheers,
> > >> hammett
> > >>http://hammett.castleproject.org/
>
> > --
> > Cheers,
> > hammett
> >http://hammett.castleproject.org/
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Castle Project Development List" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/castle-project-devel?hl=en
-~----------~----~----~----~------~----~------~--~---
