Hi, I'd like to get your opinion on one aspect of IInterceptorSelector support implementation in DP2.
The way I implemented it now (you can see the patch here: http://support.castleproject.org/projects/DYNPROXY/issues/view/DYNPROXY-ISSUE-37) is that interceptorSelector is an instance field on proxy that is passed via .ctor I'm thinking if it should be this way. Preferably, I'd have it be static. 1. First of all, InterceptorSelector, being part of the ProxyGenerationOptions is the part of CacheKey, so by definition if it changes, a new proxy type will get generated. As long as it's identical, each call to GenerateProxyTypeXYZ will return the same type. Moreover, since it's already part of ProxyGenerationOptions, which gets set as a static field on proxy type, there's no need for separate field for InterceptorSelector at all. Anytime it's needed, it can be retrieved from ProxyGenerationOptions instance. It also removes any need to add code to serialize or deserialize it. So, to sum it up, not having it as instance field would greatly reduce size of the patch, size of the proxy class, and would work just as well, if not better. Or am I missing any important scenario that can't be covered by that? CONFIDENTIALITY NOTICE This message is intended exclusively for the individual or entity to which it is addressed. This communication may contain information that is proprietary, privileged, confidential or otherwise legally exempt from disclosure. If you are not the named addressee, you are not authorized to read, print, retain, copy or disseminate this message or any part of it. If you have received this message in error, please delete all copies of this message and notify the sender immediately by return mail or fax ATSI S.A.(+4812) 285 36 04. Any email attachment may contain software viruses which could damage your own computer system. Whilst reasonable precaution has been taken to minimise this risk, we cannot accept liability for any damage which you sustain as a result of software viruses. You should therefore carry out your own virus checks before opening any attachments. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Castle Project Development List" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/castle-project-devel?hl=en -~----------~----~----~----~------~----~------~--~---
