I went ahead and created a patch leaving this overload in the code. The issue and patch are NVELOCITY-ISSUE-32.
Sean Carpenter On Jan 7, 2:10 pm, scarpen <[email protected]> wrote: > I've come across a bug in the NVelocity StringTokenizer class. If a > string to be tokenized contains part of one token repeated in another > token, that second token will be tokenized incorrectly. For example, > if the string to be tokenized is "Test1,Test1234" the tokens returned > will be "Test1" and "234". While I was working on a patch, I noticed > that there is an overload of the NextToken() method that allows you to > change delimiters during tokenization. This makes the tokenization > much harder. > > My question is whether or not this overload can be removed (or changed > to throw an exception). It's not used anywhere in the NVelocity > source, but it is public. I can't come up with a good reason to > change delimiters in the middle of tokenizing a string, but maybe I'm > missing something. > > I can submit a patch for the issue once I have some guidance on > whether or not this overload needs to be supported. > > Thanks, > Sean Carpenter --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Castle Project Development List" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/castle-project-devel?hl=en -~----------~----~----~----~------~----~------~--~---
