+1 on that - very high quality patch! On Thu, Feb 12, 2009 at 2:14 AM, Ken Egozi <[email protected]> wrote:
> nonsense. > I appreciate the great job on this patch. > > On Wed, Feb 11, 2009 at 5:04 PM, Mike Nichols <[email protected]>wrote: > >> >> Thanks Ken ... 'preciate it >> >> On Feb 11, 7:57 am, Ken Egozi <[email protected]> wrote: >> > Personally I'm very much +1 for this one. >> > Unless there's any objection I think I'll apply this one >> > >> > On Wed, Feb 11, 2009 at 4:42 PM, Mike Nichols <[email protected] >> >wrote: >> > >> > >> > >> > >> > >> > > Not to be pushy (I know everyone is busy ) >> > > .. but I was wondering if one of the Components leads could have a >> > > look at this patch: >> > > >> http://support.castleproject.org/projects/COMP/issues/view/COMP-ISSUE-82 >> > >> > > It completely refactors DefaultConverter away from all the conditional >> > > logic that is in there (and consequently makes it hard to follow). It >> > > makes adding converters for new types a snap, too. >> > >> > > I have a TimeSpan converter I want to contribute but is predicated >> > > upon this refactoring. But before i go too far in my own project I >> > > want to see if the patch might be included. Even if noone has time to >> > > apply it I was just hoping to know it would be at some point. >> > >> > > thanks >> > > mike >> > >> > -- >> > Ken Egozi. >> http://www.kenegozi.com/bloghttp://www.delver.comhttp://www.musicglue.comhttp://www.castleproject.orghttp://www.gotfriends.co.il >> >> > > > -- > Ken Egozi. > http://www.kenegozi.com/blog > http://www.delver.com > http://www.musicglue.com > http://www.castleproject.org > http://www.gotfriends.co.il > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Castle Project Development List" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/castle-project-devel?hl=en -~----------~----~----~----~------~----~------~--~---
