Thanks Krzysztof and Fabio. Applied in r5562. At some stage we should probably refactor this to use the MethodSignatureComparer.
On Wed, Feb 25, 2009 at 6:34 PM, Krzysztof Kozmic <[email protected]>wrote: > Hi, > > I created a fix for DYNPROXY-ISSUE-82. > > Unfortunately I cant access the SVN repository right now, so I can't creat > a proper patch. > > Here's the code needed to make it work, feel free someone to create a > patch out of it (or I will when I get access to svn tonight or tomorrow). > > Put this code in InterfaceProxyWithTargetGenerator.IsEquivalentMethod > method instead of "return true;" at the very bottom of the method: > > var sourceGenericArguments = methodOnInterface.GetGenericArguments(); > var targetGenericArguments = methodInfo.GetGenericArguments(); > > if(sourceGenericArguments.Length!=targetGenericArguments.Length) > { > return false; > } > for( int i = 0; i < sourceGenericArguments.Length; i++ ) > { > var sourceGenericArgument = sourceGenericArguments[i]; > var targetGenericArgument = targetGenericArguments[i]; > if(!IsTypeEquivalent( > sourceGenericArgument,targetGenericArgument )) > { > return false; > } > } > > return true; > > I ran all the Windsor/MK/DP2 tests with this change and they all pass. > > I'm not sure if similar change is not required in ClassProxyGenerator due > to massive code duplication between those two. > > cheers > > Krzysztof > > > > > CONFIDENTIALITY NOTICE > > This message is intended exclusively for the individual or entity to which it > is addressed. This communication may contain information that is proprietary, > privileged, confidential or otherwise legally exempt from disclosure. If you > are not the named addressee, you are not authorized to read, print, retain, > copy or disseminate this message or any part of it. If you have received this > message in error, please delete all copies of this message and notify the > sender immediately by return mail or fax ATSI S.A.(+4812) 285 36 04. > > Any email attachment may contain software viruses which could damage your own > computer system. Whilst reasonable precaution has been taken to minimise this > risk, we cannot accept liability for any damage which you sustain as a result > of software viruses. You should therefore carry out your own virus checks > before opening any attachments. > > > -- Jono --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Castle Project Development List" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/castle-project-devel?hl=en -~----------~----~----~----~------~----~------~--~---
