yeah - thx a bunch. nice one to spot and fix :) On Tue, Jun 16, 2009 at 11:45 PM, Roelof Blom <[email protected]> wrote:
> Applied in r5774, many thanks! > > > On Tue, Jun 16, 2009 at 6:34 PM, Dan Ports <[email protected]> wrote: > >> r5659 fixed the original problem, but introduced another one: >> EmailTemplateService now inserts a blank line at the beginning of every >> message. The commit message for r5659 mentions needing to insert a blank >> line to adhere to RFC 2822, but this is redundant because the .NET framework >> does that already when sending a Message object. So the final message sent >> has two blank lines between the headers and the body. >> The attached patch should resolve this issue. >> >> Dan >> >> >> On Tue, May 5, 2009 at 3:35 PM, Dan Ports <[email protected]> wrote: >> >>> OK, looks good, thanks. >>> Dan >>> >>> >>> On Tue, May 5, 2009 at 3:11 PM, Roelof Blom <[email protected]>wrote: >>> >>>> Thanks for spotting this: fixed in r5659 >>>> >>>> -- Roelof. >>>> >>>> >>>> On Tue, Apr 28, 2009 at 2:46 PM, Dan Ports <[email protected]> wrote: >>>> >>>>> Hello, >>>>> Just curious as to why EmailTemplateService on trunk deletes all blank >>>>> lines in a message body (lines 234-237). The RC3 behavior was to preserve >>>>> these, so upgrading from RC3 to trunk broke our email formatting a bit. >>>>> It's >>>>> not a bit deal, and we worked around it by inserting a space on all blank >>>>> lines, but could anyone shed some light on why this change was made or >>>>> whether it is a regression? It looks like hammett made this change in >>>>> r4647 >>>>> on the IController branch. >>>>> >>>>> Thanks, >>>>> Dan >>>>> >>>>> >>>>> >>>> >>>> >>>> >>> >> >> >> > > > > -- Ken Egozi. http://www.kenegozi.com/blog http://www.delver.com http://www.musicglue.com http://www.castleproject.org http://www.gotfriends.co.il --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Castle Project Development List" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/castle-project-devel?hl=en -~----------~----~----~----~------~----~------~--~---
