I don't think core.autocrlf can be changed at this stage? You have to live with no line-ending conversions. Otherwise you have to convert your existing working tree, which is not an easy task.
On 30/03/2010, at 01.32, John Simons wrote: > I don't really see a problem with using github pull requests, as long > as we document how we want the users to use it, eg. leave the default > users ticked. > That way all committers get notified by email and anyone can act on > it. > Regarding user "castleproject", can we associate this user with > [email protected], so that pull requests get > emailed to the list? > >> instead recommend people to post on this group. > I don't like the idea of sending emails to this list, I much rather > use the issue tracker for that, after all that is what is for. > >> On patches vs forking: I'd recommend patches only for very trivial, >> single-file fixes, which can be posted and reviewed on this group. >> Otherwise, fork. > agree, but once again we need to document or provide links to eg > http://wiki.github.com/rakudo/rakudo/frews-recommended-workflow > > Also are we turning on core.autocrlf ? > > Cheers > John > > > On Mar 30, 9:57 am, Mauricio Scheffer <[email protected]> > wrote: >> For Castle, I'd just forget about github's pull request feature and instead >> recommend people to post on this group. Something like: >> >> "Hi Castle team, I have implemented/fixed/improved such and such for <insert >> project> here:http://github.com/maxild/Castle.Core/tree/dev, please review >> it / merge it" >> >> IMHO github's pull request is only useful if there's a single central >> maintainer. But in Castle, nobody really owns the user "castleproject". >> >> On patches vs forking: I'd recommend patches only for very trivial, >> single-file fixes, which can be posted and reviewed on this group. >> Otherwise, fork. >> >> Comments? >> >> Cheers, >> Mauricio >> >> On Mon, Mar 29, 2010 at 7:22 PM, Morten Maxild <[email protected]> wrote: >>> The docs say that by default, you will see everyone who has a project in >>> your projects 'network'. Because I forked castle.core I am there too;-( >> >>> I agree this may seem unfortunate, but github has all forks on an equal >>> footing. Maybe the confusing thing right now is that so many people are >>> receiving the pull request by default (15 seems like a lot of people >>> considering the size of the network?). As more and more people are forking >>> (to create their own branches, and contributing changes) most contributors >>> will not add recipients by hand, and the recipients added by default, >>> should >>> be the right people. I cannot say if the default recipients are the right >>> people, because I know very little about Castle project. >> >>> For a popular project like jquery there are 197 people in their network, >>> and >>> rails has 899 people. The pull request dialog has a checkbox list for >>> everyone, but only 'core' people are chosen by default! >> >>> I know we are foremost talking about improving the pull request workflow on >>> github, but maybe the move away from centralized control of revisions, to >>> decentralized branching/forking and merging of tracked changes plays a role >>> here? >> >>> Cheers >>> Maxild >> >>> ----Original Message----- >>> From: [email protected] >>> [mailto:[email protected]] On Behalf Of John Simons >>> Sent: 29. marts 2010 22:55 >>> To: Castle Project Development List >>> Subject: Re: Create a patch article >> >>> Actually it gets even worse. >>> Now if you try to do a pull request "maxild" appears in the list as >>> well, for all castle projects! >>> So, does this mean that every time we merge a pull request the user >>> that sent it gets automatically added to the list? >> >>> Cheers >>> John >> >>> On Mar 30, 5:52 am, Michael Davis <[email protected]> wrote: >>>> Are there any guidelines on which people to include on a pull request? >> >>>> I've got a patch for Windsor I'd like to submit >>> (seehttp://groups.google.com/group/castle-project-users/browse_frm/thread. >>> .. >> >>> andhttp://groups.google.com/group/castle-project-users/browse_frm/thread. >>> .. >>>> ), and when I go to make the pull request, there are 15 accounts >>>> selected by default and 5 more that aren't. >> >>>> Is it preferred to send the request to all of the people selected by >>>> default, or should I limit it to just a few or one? And if I limit >>>> the request, who should get it? >> >>>> If any of this depends on the project, then that definitely should be >>>> documented somewhere, as well. >> >>>> Thanks, >>>> Michael Davis >> >>>> On Mar 25, 3:55 pm, John Simons <[email protected]> wrote: >> >>>>> Also should we add to each repository a readme file with info like >>>>> this:http://github.com/DarthFubuMVC/fubumvc#readme >> >>>>> Cheers >>>>> John >> >>>>> On Mar 26, 7:49 am, Simon <[email protected]> wrote: >> >>>>>> perhaps just point to a few intros on github and git? >> >>> eghttp://help.github.com/forking/http://kylecordes.com/2008/04/30/git-w... >> >>>>>> On Mar 24, 10:03 am, John Simons <[email protected]> wrote: >> >>>>>>> We also need to update the Release Guide >>> -http://www.castleproject.org/community/releaseguide.html >> >>>>>>> Cheers >>>>>>> John >> >>>>>>> On Mar 24, 9:42 am, Henry Conceição <[email protected]> >>> wrote: >> >>>>>>>> Hi mates, >> >>>>>>>> I did update all the subversion mentions on the website and >>> pointed to >>>>>>>> github or the git repository. The only exception is the create a >>> patch >>>>>>>> page. >> >>>>>>>> @git experts: can someone update it with a nice guide, please? >> >>>>>>>> Cheers, >>>>>>>> Henry Conceição >> >>> -- >>> You received this message because you are subscribed to the Google Groups >>> "Castle Project Development List" group. >>> To post to this group, send email to [email protected] >>> . >>> To unsubscribe from this group, send email to >>> [email protected]<castle-project-devel%[email protected]> >>> . >>> For more options, visit this group at >>> http://groups.google.com/group/castle-project-devel?hl=en. >> >>> -- >>> You received this message because you are subscribed to the Google Groups >>> "Castle Project Development List" group. >>> To post to this group, send email to [email protected] >>> . >>> To unsubscribe from this group, send email to >>> [email protected]<castle-project-devel%[email protected]> >>> . >>> For more options, visit this group at >>> http://groups.google.com/group/castle-project-devel?hl=en. > > -- > You received this message because you are subscribed to the Google Groups > "Castle Project Development List" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/castle-project-devel?hl=en. > -- You received this message because you are subscribed to the Google Groups "Castle Project Development List" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/castle-project-devel?hl=en.
