pulled, thanks
K
On 12/06/2010 10:01 PM, TigerShark wrote:
Just sent a pull request.
On 12 Jun., 13:53, TigerShark<[email protected]> wrote:
Hmm, I got it now... Apparently I had to disable AutoCrlf in the
config. After I did that, it registered the changed lines correctly.
That is really something that shouldn't be an issue nowadays... :|
On 12 Jun., 13:47, TigerShark<[email protected]> wrote:
Hi again
I'm now onwards, but I'm really getting frustrated about Git (or
TortoiseGit). Why does it keep insisting that every single line has
changed when I want to commit. The UnifiedDiff tool tells me that I
have deleted 250 lines and inserted 271!
I know it might be irrelevant, but it is really getting on my nerves!
I have tried WinMerge to tell the differences between the files, but
it sees the real changes only. I simply don't get why Git can't see
that...
What should I do about that? Ditch Tortoise and use GitBash instead
(or does that not make any difference)?
Furthermore, I'm on Windows 7, and all files in Castle.Core is encoded
in codepage 1252 instead of UTF-8. Is that okay?
Kenneth
On 11 Jun., 11:48, John Simons<[email protected]> wrote:
Hi Kenneth
To start contributing to a Castle project just pick the project and read a
guide like
http://docondev.blogspot.com/2010/02/contributing-to-project-you-find...
To contribute doco all u need to do is create an account on our wiki site
(http://stw.castleproject.org/) and start typing.
Hope this helps
Cheers John
On 11/06/2010, at 18:03, TigerShark<[email protected]> wrote:
Hi,
I can't find anything in the Castle repo (hub?) that gives me the
option to do a pull request. Do I have to be a contributor or
something like that?
I've actually wanted to contribute in a while (documentation, code
comments and stuff), but haven't really found any easy way to do that :
(
Kenneth
On 10 Jun., 11:07, John Simons<[email protected]> wrote:
Hi Kenneth,
Just send us a pull request, seehttp://github.com/guides/pull-requests
Cheers
John
________________________________
From: TigerShark<[email protected]>
To: Castle Project Development List<[email protected]>
Sent: Thu, 10 June, 2010 7:00:15 PM
Subject: Re: Provide parameterless constructor for DefaultSmtpSender
Hi,
I have tried to create a patch, but I can't get Git to understand the
line endings (everything has changed in my patch).
Is there any guidance on this? I use TortoiseGit with msysgit (I have
absolutely no idea about what's what and why... :) )
Kenneth
On 9 Jun., 22:00, Mauricio Scheffer<[email protected]>
wrote:
Having that constructor, and all the credentials properties, etc in
DefaultSmtpSender makes it possible to have several DefaultSmtpSender
instances using different hostnames, credentials, etc. So it is more
flexible than having only one configuration for all SmtpClient
instances.
However I don't see anything wrong in adding a parameterless
constructor... can you submit a patch?
--
Mauricio
On Jun 9, 6:59 am, TigerShark<[email protected]> wrote:
Hi,
I just noticed that the DefaultSmtpSender requires a host name in it's
constructor. This seems kind of strange to me, since the SmtpClient
used to configure DefaultSmtpSender, already provide this information
through it's own configuration section.
I like the DefaultSmtpSender implementation, but it's annoying not to
be able to register it in Windsor, unless I provide the host name as a
parameter. At the moment it's even quite difficult retrieving the host
name from the system.net.smtp section, which is used to configure the
SmtpClient.
Any suggestions? I'm aware I might be a bit off track here, as a
search in the list didn't result in similar questions...
Kenneth
--
You received this message because you are subscribed to the Google Groups "Castle
Project Development List" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group
athttp://groups.google.com/group/castle-project-devel?hl=en.
--
You received this message because you are subscribed to the Google Groups "Castle
Project Development List" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group
athttp://groups.google.com/group/castle-project-devel?hl=en.
--
You received this message because you are subscribed to the Google Groups "Castle
Project Development List" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/castle-project-devel?hl=en.
