Jordan, I did review your patch, and read the group archives to catch up with the read only transaction loop, and I'm not sure if it's the right thing to do. Your use case for this feature was:
- transaction one get rolledback - transaction two gets commited - the session was shared and the changes rolled back by tx1 where commited by tx2. And to tackle it, your suggestion was to introduce the read only transactions. First, why open the tx2 instead the oly create a read only session? Second, I don't think that it's can be implemented in a consistent way. For the NHibernate Facility what truly happens on a read only scenario is that an transaction is never started and the session is never flushed. Which can useful in many scenarios. But when it comes to the transaction itself, things gets more complicated. On your patch, even on a readonly transaction the commit and rollback steps are still been executed. So: - What happens if another resources were enlisted? For example, how should a file system tx should behave in a read only scenario? - How the TransactionScope and a ReadOnly transaction would interact? imo would be a lot more simpler to only provide a way to signal the nhibernate facility to not enlist and flush the session. What do you think? Cheers, Henry Conceição 2010/9/24 Henry Conceição <[email protected]>: > Will do. > > Cheers, > Henry Conceição > > > > 2010/9/24 Krzysztof Koźmic <[email protected]>: >> can someone with better understanding of the facility than myself pick >> up this pull request, review and integrate? >> >> cheers, >> Krzysztof >> >> On Aug 17, 7:36 pm, Jordan Muscott <[email protected]> wrote: >>> inline >>> >>> On Aug 13, 4:30 pm, Chris Canal <[email protected]> wrote: >>> >>> > I would try doing a fresh checkout and moving your changes across. The >>> > reformatting happens when you checkout and won't apply to anything you >>> > have >>> > already checked out >>> >>> Ok, yeah fair enough, I'll have to. >>> I did try reformating and re-committing but it looks like it didn't >>> work. >>> >>> Jordan. >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Castle Project Development List" group. >> To post to this group, send email to [email protected]. >> To unsubscribe from this group, send email to >> [email protected]. >> For more options, visit this group at >> http://groups.google.com/group/castle-project-devel?hl=en. >> >> > -- You received this message because you are subscribed to the Google Groups "Castle Project Development List" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/castle-project-devel?hl=en.
