One question we should answer is - what if one of the selected handlers is unresolvable?
Should we throw or should we skip it.

Currently when we call ResolveAll we TryResolve handlers and just skip them if we can't. In here though, the IHandlerFilter explicitly picks those it wants, so one could argue that we should throw if any of them is not resolvable.

I'd stick to the current behavior (ignore) but I'm open for compelling arguments for the other option.

Also I'd like IHandlerSelector and IHandlerFilter to have more unified name. They do pretty much the same thing, so it would be good to have their names suggest that.

Krzysztof


On 20/01/2011 9:17 PM, Mogens Heller Grabe wrote:
Hi Group!

I have made an implementation of a "multi handler selector", or
"handler filter" as I have called it.

I would be extremely happy if someone would review the code and tell
me what I have messed up, what I didn't consider because I'm a n00b,
etc. :)

It's analoguous to IHandlerSelector, except that IHandlerFilter does
not take a key as argument, and it must return an array of handlers.
The logic is implemented in DefaultNamingSubSystem.

The commit is here: 
https://github.com/mookid8000/Castle.Windsor/commit/683e9a227dd3591989aa6a0886fc7dd5195fbf59

Thanks in advance!


--
You received this message because you are subscribed to the Google Groups "Castle 
Project Development List" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/castle-project-devel?hl=en.

Reply via email to