John,

make sure you're using tabs not spaces and have some actual tests that verify that works as expected.

Krzysztof

On 31/03/2011 10:43 AM, John Simons wrote:
Done
https://github.com/castleproject/Castle.Windsor/pull/8



------------------------------------------------------------------------
*From:* Krzysztof Koźmic <[email protected]>
*To:* [email protected]
*Sent:* Thursday, 31 March 2011 11:21 AM
*Subject:* Re: Why is CustomLifestyleAttribute sealed?

Awesome,

you can also provide a pull request for it if you want ;) #hint

On 31/03/2011 10:12 AM, Kenneth Siewers Møller wrote:
Done. http://issues.castleproject.org/issue/IOC-283

2011/3/29 Krzysztof Koźmic <[email protected] <mailto:[email protected]>>

    hmmm,

    right.

    OK, I see your point. (you can tell I just got up and didn't have
    my coffee yet).

    I guess that could be fixed. Please log it to the issue tracker.


    On 30/03/2011 7:30 AM, Kenneth Siewers Møller wrote:
    Yeah, but how do i tell it which LifestyleManager to use?

    2011/3/29 Krzysztof Koźmic <[email protected]
    <mailto:[email protected]>>

        On top of what Mauricio said, don't worry about CLA. if you
        want to create a lifestyle use LifestyleAttribute as your
        base and it will work just as well, you only need to pass
        LifestyleType.Custom to the base .ctor.

        Krzysztof


        On 29/03/2011 10:22 PM, TigerShark wrote:

            Hi,

            I would like to create a custom lifestyle attribute (using
            HttpContext.Session), but I can't create my own
            attribute inherit from
            CustomLifestyleAttribute as it is sealed :(

            Now I have to do:
            [CustomLifestyle(typeof(PerSessionLifestyleManager))]

            Instead of just:
            [SessionLifestyle]

            Am I on the wrong path or is there an explanation for
            this design
            decission?


            Kenneth


-- You received this message because you are subscribed to the
        Google Groups "Castle Project Development List" group.
        To post to this group, send email to
        [email protected]
        <mailto:[email protected]>.
        To unsubscribe from this group, send email to
        [email protected]
        <mailto:castle-project-devel%[email protected]>.
        For more options, visit this group at
        http://groups.google.com/group/castle-project-devel?hl=en.




-- Med venlig hilsen / Kind regards
    Kenneth Siewers Møller

-- You received this message because you are subscribed to the
    Google Groups "Castle Project Development List" group.
    To post to this group, send email to
    [email protected]
    <mailto:[email protected]>.
    To unsubscribe from this group, send email to
    [email protected]
    <mailto:[email protected]>.
    For more options, visit this group at
    http://groups.google.com/group/castle-project-devel?hl=en.

-- You received this message because you are subscribed to the
    Google Groups "Castle Project Development List" group.
    To post to this group, send email to
    [email protected]
    <mailto:[email protected]>.
    To unsubscribe from this group, send email to
    [email protected]
    <mailto:castle-project-devel%[email protected]>.
    For more options, visit this group at
    http://groups.google.com/group/castle-project-devel?hl=en.




--
Med venlig hilsen / Kind regards
Kenneth Siewers Møller

--
You received this message because you are subscribed to the Google Groups "Castle Project Development List" group. To post to this group, send email to [email protected] <mailto:[email protected]>. To unsubscribe from this group, send email to [email protected] <mailto:[email protected]>. For more options, visit this group at http://groups.google.com/group/castle-project-devel?hl=en.

--
You received this message because you are subscribed to the Google Groups "Castle Project Development List" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/castle-project-devel?hl=en.


--
You received this message because you are subscribed to the Google Groups "Castle Project Development List" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/castle-project-devel?hl=en.

--
You received this message because you are subscribed to the Google Groups "Castle 
Project Development List" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/castle-project-devel?hl=en.

Reply via email to