Rémi,
Thanks for the work.
Did you mean TortoiseGit rather than TortoiseSvn?
Make sure you use Tabs rather than spaces. And then, once you've cleaned
up the formatting, go ahead and create a GitHub pull request.
-rb
On 1/27/2012 3:07 AM, Rémi BOURGAREL wrote:
I'm fighting with git (I'm just know the svn way of doing things) and
I'll add it to my fork... (I could use the castle.monorail gitwith
tortoisesvn but I can't with castle.core, that's odd)
Rémi
Le 26 janvier 2012 20:36, hammett <[email protected]
<mailto:[email protected]>> a écrit :
Patch? :-)
2012/1/26 Rémi BOURGAREL <[email protected]
<mailto:[email protected]>>:
> If we specify some fields to ignore they are still getting
validated.
>
> The following test fails
>
>
>> [Test]
>> public void IgnoredFieldsNotValidated()
>> {
>> var args = new NameValueCollection { { "person.Email",
>> string.Empty }};
>> object instance = binder.BindObject(typeof(Person),
>> "person","person.Email",null, builder.BuildSourceNode(args));
>>
>> Assert.IsNotNull(instance);
>> Assert.AreEqual(0, binder.ErrorList.Count);
>> }
>
>
>> Expected: 0
>> But was: 1
>
>
>
> The best solutions would be to add a call to
ShouldIgnoreProperty in the
> function CheckForValidationFailures, the validation will still
be done but
> it won't be added to the error list. Because it seems that it
will be too
> muche complicated to add the ignored properties list to the
validation
> interface (IValidatorRunner and IValidatorPerformer).
>
> no ?
>
>
>
>
>
>
>
> --
> You received this message because you are subscribed to the
Google Groups
> "Castle Project Development List" group.
> To view this discussion on the web visit
> https://groups.google.com/d/msg/castle-project-devel/-/Oks1eu7Ehi8J.
> To post to this group, send email to
[email protected]
<mailto:[email protected]>.
> To unsubscribe from this group, send email to
> [email protected]
<mailto:castle-project-devel%[email protected]>.
> For more options, visit this group at
> http://groups.google.com/group/castle-project-devel?hl=en.
--
Cheers,
hammett
http://hammett.castleproject.org/
--
You received this message because you are subscribed to the Google
Groups "Castle Project Development List" group.
To post to this group, send email to
[email protected]
<mailto:[email protected]>.
To unsubscribe from this group, send email to
[email protected]
<mailto:castle-project-devel%[email protected]>.
For more options, visit this group at
http://groups.google.com/group/castle-project-devel?hl=en.
--
Rémi BOURGAREL
Téléphone : +336 49 16 78 57
Adresse : 82 Rue Matabiau , 31 000 Toulouse, France
--
You received this message because you are subscribed to the Google
Groups "Castle Project Development List" group.
To post to this group, send email to
[email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/castle-project-devel?hl=en.
--
You received this message because you are subscribed to the Google Groups "Castle
Project Development List" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/castle-project-devel?hl=en.