Applied in r5982. Thanks. On Wed, Sep 2, 2009 at 7:22 AM, John Simons <[email protected]>wrote:
> > Ooops, Patch updated. > > On Sep 1, 11:35 pm, Jonathon Rossi <[email protected]> wrote: > > Sorry Andy, I have been really busy for the last few months. Things are > > finally coming to an end at work. > > > > John, the patch is missing ClassWithVirtualProperty.cs. Thanks for making > it > > easier for me to review and apply. > > > > On Tue, Sep 1, 2009 at 9:17 PM, schlachtzeuger <[email protected] > >wrote: > > > > > > > > > > > > > sure, didn't know that > > > > > On Sep 1, 11:56 am, John Simons <[email protected]> wrote: > > > > Andy, > > > > > > I've submitted your patch + test with a few changes in Donjon. > > > > You can follow its progress by going tohttp:// > > > support.castleproject.org/projects/COMP/issues/view/COMP-ISSUE... > > > > > > Next time please submit the test as a patch as well, it makes it > > > > simpler for us. > > > > > > Thanks for the patch and test > > > > John > > > > > > On Aug 31, 9:55 pm, schlachtzeuger <[email protected]> wrote: > > > > > > > push up > > > > > > > On Aug 6, 1:34 am, schlachtzeuger <[email protected]> > wrote: > > > > > > > > ok .. the response worked, just use the same subject ;) > > > > > > > > On Jul 29, 1:53 pm, Andy Bicksbo <[email protected]> > wrote: > > > > > > > > > Hi > > > > > > > > > ... this is my original post: > > >http://groups.google.com/group/castle-project-users/browse_thread/thr. > .. > > > > > > > > > However I'm unable to respond to that post via the groups > website > > > and add an > > > > > > > attachment (any help appreciated) > > > > > > > > > Here is the response: > > > > > > > > > sorry for the delay, i was burried deep in work. in the > attachment > > > is a > > > > > > > project with the testcases. > > > > > > > > > Although the fix is just one line i would really appreciate if > you > > > us the > > > > > > > patch cause it extracts a protected virtual method, which makes > it > > > more > > > > > > > extensible, and fixes the problem. ... and i really need this > > > extension > > > > > > > points in my projects and its not that funny to run custom > builds > > > ;) > > > > > > > > > thx > > > > > > > > > CachedValidationRegistry.patch > > > > > > > 1KViewDownload > > > > > > > > > CastleTestCase.rar > > > > > > > 415KViewDownload- Hide quoted text - > > > > > > > > - Show quoted text -- Hide quoted text - > > > > > > - Show quoted text - > > > > -- > > Jono > > > -- Jono --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Castle Project Users" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/castle-project-users?hl=en -~----------~----~----~----~------~----~------~--~---
