Farrukh Najmi wrote:
>
> Just curious. Is there some protocol by which one can find out what is the
> disposition of a patch submitted by one. I had submitted this patch and would
> like to know if/when it will be incoporated in the code base. Thanks for
> helping me understand the patch process.
There is no formal protocol. Patches can be submitted via the mailing
list or bugzilla. In each case the patch will be reviewed by a
committer. If the patch is deemed valid or beneficial it will be
committed and you will be notified in the same manner in which the patch
was submitted (mailing list or bugzilla). If the patch is rejected you
will be given an explanation. Modifications to the patch may be made by
the committers.
Keep in mind that most of the committers (including all JDO committers)
are working in the own "spare time", so we ask that you be patient with
us while we find the time to review patches and bug reports.
Thanks,
--Keith
>
> Farrukh Najmi wrote:
>
> > Problem Fixed
> > ---------------
> > Prior to the proposed change the following attribute declaration with
> > type="langauge":
> >
> > <attribute name = "lang" default = "en-us" form = "qualified" type =
> > "language"/>
> >
> > would cause a warning to be generated and the resulting code to not be
> > compilable.
> >
> > Attached is a proposed enhancement that does two things:
> >
> > 1. Treats the type="language" in an attribute same as if it were
> > type="string". The resulting code compiles and is usable. It does not do
> > the validation on the string
> >
> > 2. Fixes the warning that was out put so that teh unsupported type is in
> > quotes. This will make the message more meaningful and obvious IMO.
> >
> > Please ask any questions and forgive me if I did not follow normal
> > procedures. I am a new contributor to castor. Thanks for a great tool.
> >
> > Index: TypeConversion.java
> > ===================================================================
> > RCS file:
> > /cvs/castor/castor/src/main/org/exolab/castor/builder/TypeConversion.java,v
> >
> > retrieving revision 1.44
> > diff -c -r1.44 TypeConversion.java
> > *** TypeConversion.java 11 Jul 2001 11:08:33 -0000 1.44
> > --- TypeConversion.java 30 Nov 2001 01:37:08 -0000
> > ***************
> > *** 284,289 ****
> > --- 284,290 ----
> > return xsQName;
> > }
> > //-- string
> > + case SimpleTypesFactory.LANGUAGE_TYPE:
> > case SimpleTypesFactory.STRING_TYPE:
> > {
> > XSString xsString = new XSString();
> > ***************
> > *** 308,315 ****
> > }
> > default:
> > //-- error
> > ! String warning = "Warning: The W3C datatype
> > "+simpleType.getName();
> > ! warning += " is not currently supported by Castor
> > Source Generator.";
> > System.out.println(warning);
> > String className
> > =
> > JavaNaming.toJavaClassName(simpleType.getName());
> > --- 309,316 ----
> > }
> > default:
> > //-- error
> > ! String warning = "Warning: The W3C datatype
> > '"+simpleType.getName();
> > ! warning += "' is not currently supported by Castor
> > Source Generator.";
> > System.out.println(warning);
> > String className
> > =
> > JavaNaming.toJavaClassName(simpleType.getName());
> >
> > --
> > Regards,
> > Farrukh
>
> --
> Regards,
> Farrukh
-----------------------------------------------------------
If you wish to unsubscribe from this mailing, send mail to
[EMAIL PROTECTED] with a subject of:
unsubscribe castor-dev
