Hi Thomas, You are right, we will no longer need the methods: - castor.jdo.Database.load( Class type, Object identity, Object object ), - castor.jdo.engine.DatabaseImpl( Class type, Object identity, Object object ),
I appreciate you adding them for OpenEJB, but as you pointed out there are problems with that. The new interface allows us to give you an instance from our pool of Entity instances that are not assigned to an entity identity when JDO wants a new instances, rather than having to pass one in the load method every time (which doesn't work). We could use the load method to successfully keep a pool of instances assigned to an entity identity for a given transaction, but JDO already does that quite well. It makes perfect to let JDO just ask us when it needs and instance rather than us having to guess when it does. Thanks for working with Alan on this, his solution gives JDO more of a full-circle approach to instance management: give JDO an instance (when it asks) through the new interface; get the instance back through the CallbackInterceptor interface. Pretty slick. Thanks! David > -----Original Message----- > From: Thomas Yip [mailto:[EMAIL PROTECTED]] > Sent: Tuesday, January 15, 2002 12:47 AM > To: [EMAIL PROTECTED] > Subject: Re: [castor-dev] [JDO] Controlling instance creation in > ClassMolder > > > > Hi Alan, > > > Thank you very much for your patch, especially appreciate that you send us > test cases as well. > I don't have time to run your test case yet. > > However, I have a minor enhancement request. First, I saw that > you create a > new interface that extends CallbackInterceptor. However, I think the new > interface would be better if it doesn't extends > CallbackInterceptor, because > it is actually not a extension of CallbackInterceptor, logically. > Could you > please make it standalone? > > Also, the method > castor.jdo.Database.load( Class type, Object identity, > Object object ), > castor.jdo.engine.DatabaseImpl( Class type, Object identity, Object > object ), > > were added, half year ago, for openEJB integration (although we > later found > that openEJB can't take advantage of that). So, I am going to remove those > methods once your patch is committed. I am quite sure it won't cause any > problem on your side, right? > > > Thank again Alan! Greatly appreciated. :-) > > > > > Thomas > > > > -----Original Message----- > >From: Alan Cabrera [mailto:[EMAIL PROTECTED]] > >Sent: Sunday, January 13, 2002 8:41 PM > >To: [EMAIL PROTECTED] > >Subject: Re: [castor-dev] [JDO] Controlling instance creation in > ClassMolder > > > >Here are my files and test cases. > > > > > > ----------------------------------------------------------- > If you wish to unsubscribe from this mailing, send mail to > [EMAIL PROTECTED] with a subject of: > unsubscribe castor-dev > ----------------------------------------------------------- If you wish to unsubscribe from this mailing, send mail to [EMAIL PROTECTED] with a subject of: unsubscribe castor-dev
