Hi Joyce,


Joyce Wong wrote:
> 
> Hi Castor Guys!
> 
> Nathan, thank you very much for explaining how this
> all works!

Yes, thanks Nathan for responding to the e-mails and providing the list
with valuable information.

> 
> I've completed all of my changes to
> ValidationException for the 0.9.3.9 source code...
> 
> So can someone adopt me and be my committer?

Well..I am a bit young to adopt anyone...but I can be your committer.
Just don't tell anyone! :-)

> 
> Should I jar up my classes and send them to you?

No. please send a diff -u against the current CVS version.

> 
> I've done some testing and it seems OK to me.
> 
> My changes should be very easy to merge in with the
> rest of the code and it's very unlikely that it will
> break any existing functionality.

Great...I'll review it when I recieve it and let you know.

Please send the diff -u to this list. That way anyone who wants to see
the patch, and those that want to use the patch can use it right away,
without waiting for review.

> 
> Look forward to getting this stuff in!
> Joyce  : )  [fingers crossed]

:-)

Thanks for you interest in contributing to the project.

--Keith

> 
> --- "Green, Nathan" <[EMAIL PROTECTED]> wrote:
> > Would someone who knows better than I please correct
> > any
> > mistakes I made here?
> > See below...
> >
> > > -----Original Message-----
> > > From: Joyce Wong [mailto:[EMAIL PROTECTED]]
> > > Sent: Monday, January 14, 2002 2:19 PM
> > > To: [EMAIL PROTECTED]
> > > Subject: Re: [castor-dev] What is the process of
> > contributing
> > > to Castor
> > >
> > >
> > > Hello Castor Folks,
> > >
> > > First, I'd really like to thank Keith, Rick and
> > > Harindrinath for helping me figure out how to
> > > "checkout" stuff from the repository.
> > Embarrassingly
> > > easy once explained but frustrating nonetheless to
> > a
> > > CVS newbie like me.
> > >
> > > Now I have some questions about the process of
> > > contributing to Castor...
> > >
> > > I downloaded 0.9.3.9 via FTP and completed all of
> > my
> > > ValidationException changes to that source code.
> > >
> > > However, I've come to understand that a CVS
> > "checkout"
> > > does not mean that I have a lock on the files so
> > I'm
> > > sorta puzzled as to how parallel development is
> > > prevented and if it is not, how are branch
> > versions
> > > consolidated?
> >
> > The 'C' in CVS means "concurrent."  It means that
> > CVS
> > was designed so that multiple developers could work
> > on
> > the same code concurrently.  More info can be
> > obtained
> > at the CVS home page (http://www.cvshome.org/)
> >
> > >
> > > I just don't know who does the merging if there's
> > > parallel development.
> >
> > That is the responsibility of the committer(s).
> >
> > >
> > > Do I just submit to someone in Castor who controls
> > the
> > > code and merges it or is it up to me to merge when
> > I
> > > check in?  If it's up to me to merge upon checking
> > in
> > > then is it OK to overwrite the checked out code
> > with
> > > my modified 0.9.3.9 FTP code and just merge when
> > > checking in?
> >
> > Ordinarily you submit a patch to a committer who
> > then
> > reviews the patch and commits the changes.
> >
> > >
> > > How should I proceed given that I've already
> > completed
> > > my changes to ~20 classes on the 0.9.3.9 source
> > code
> > > that I downloaded via FTP?  i.e. I don't have
> > anything
> > > currently checked out from CVS.
> >
> > To compare a directory:
> >    diff -ur OldSourceDir NewSourceDir > PatchFile
> >
> > To compare a single file:
> >    diff -u OldFile NewFile > PatchFile
> >
> > The utility diff is present on most Unix-type
> > systems.
> > If you are using windows, you can get diff (and many
> > other
> > utilities) here:
> >
> >
> http://www.weihenstephan.de/~syring/win32/UnxUtils.html
> >
> > >
> > > Also, Castor seems to want test cases but I don't
> > know
> > > how I am to submit them.  Where do I put the test
> > > cases?
> >
> > I suppose you would send them along with your
> > patches.
> >
> > >
> > > Thanks for all your help,
> > > Joyce  : )
> > >
> > > --- Keith Visco <[EMAIL PROTECTED]> wrote:
> > [SNIP]
> >
> >
> -----------------------------------------------------------
> >
> > If you wish to unsubscribe from this mailing, send
> > mail to
> > [EMAIL PROTECTED] with a subject of:
> >       unsubscribe castor-dev
> >
> 
> ______________________________________________________________________
> Web-hosting solutions for home and business! http://website.yahoo.ca
> 
> -----------------------------------------------------------
> If you wish to unsubscribe from this mailing, send mail to
> [EMAIL PROTECTED] with a subject of:
>         unsubscribe castor-dev

----------------------------------------------------------- 
If you wish to unsubscribe from this mailing, send mail to
[EMAIL PROTECTED] with a subject of:
        unsubscribe castor-dev

Reply via email to