Bruce, in difference to the last patch I did the following:
- reviewed oracle SQL scripts and corrected some minor errors. You will find them
under test/jdo/scripts. If you like them check
them in, but they are not required for the patch.
- corrected some minor bugs from myself in test.jdo.mapping.xml and
test.jdo.TypeConversion.java
- added a test for the values written to the database into test.jdo.TypeConversion.java
- setup a test enviroment on our oracle9i server and run the testcases
I hope that will make it easier for you to test the patch and process it into CVS.
Ralf
----- Original Message -----
From: "Bruce Snyder" <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>
Sent: Tuesday, February 18, 2003 7:31 AM
Subject: Re: [castor-dev] Enhancement (Bug 1209) Converter boolean(true)->numeric(-1)
> This one time, at band camp, Ralf Joachim said:
>
> RJ>I added a parameterized converter for boolean->numeric and boolean->integer.
> RJ>
> RJ>To allow concurrent access to a remote database from castor and e.g. MS Access/MS
>VisualBasic boolean true have to be converted
to
> RJ>numeric -1.
> RJ>
> RJ> <field name="flagWithMinusOneForTrue" type="boolean">
> RJ> <sql name="flag" type="integer[-]"/>
> RJ> </field>
> RJ>
> RJ>I had to change SQLTypes.java to get the expected results. I tested the patch
>with my own application.
> RJ>
> RJ>The modified TestCases for this conversion have not been executed. As the
>TestCase do not test the value write to the database,
I
> RJ>think the test should extended to check this also.
> RJ>
> RJ>If you agree with this I can extend the testcase?
> RJ>
> RJ>I also changed documentation, but as diff showed very strange results with this
>file I send the whole types.html.
> RJ>
> RJ>Can you please commit this enhancement into CVS?
>
> Ralf,
>
> I'll take a look at your tests as soon as I have the time. Contributions
> that include test cases usually get processed and into CVS much
> faster than those that don't. So thank you very much for you hard
> work.
>
> Bruce
> --
>
> perl -e 'print unpack("u30","<0G)U8V4\@4VYY9&5R\"F9E<G)E=\$\!F<FEI+F-O;0\`\`");'
>
> -----------------------------------------------------------
> If you wish to unsubscribe from this mailing, send mail to
> [EMAIL PROTECTED] with a subject of:
> unsubscribe castor-dev
>
bool-num-conv.zip
Description: Zip compressed data
