Hi Stein,
"Stein M. Eliassen" wrote:
>
> Bruce Snyder wrote:
> > This one time, at band camp, Stein M. Eliassen said:
> > SME>I'm asking because I was thinking of modifying ParseTreeNode to use
> > SME>ArrayList and Iterator instead...
> >
> > The replacement of the Castor OQL engine with the ANTLR implementation
> > is the next item on which I will be working. I'd say submit your patches
> > via a Bugzilla report bearing in mind that they might be added to CVS
> > only to be replaced by the ANTLR impl very soon.
> >
>
> Ok, I've changed the code and changed it to lazy-load the ArrayList to
> reduce the number of instances created.
>
> I also did change xml.Marshaller and
> xml.util.ClassDescriptorResolverImpl to lazy-load it's variables.
>
> Any comments on the lazy-loading changes?
>
Thanks for taking the time to contribute to the project. It's great to
see some additional effort going into the performance/efficiency side of
things.
I do have a few concerns over you patch however...
Your patch files remove all the changes that have been made recently
(last couple of days) to Castor XML. So you may want to update your
version before generating the diffs so that those changes are not lost
by anyone who applies your patch.
Also, why do you need to "lazy-load" "all" the variables in the
Marshaller? Most, if not all, those variables need to be initialized
immediately upon the first call to marshal an Object instance, so I
don't necessarily see the need for not initializing them upfront. Did
you do some performance tests before making those changes? If so, can
you share those tests with us and the results of those tests.
Thanks again for your efforts on the project.
--Keith
-----------------------------------------------------------
If you wish to unsubscribe from this mailing, send mail to
[EMAIL PROTECTED] with a subject of:
unsubscribe castor-dev
