* On Tue, May 06 2008, Dmitriy S. Sinyavskiy wrote:
> The -diff
>
> Index: Catalyst.pm
> ===================================================================

Please regenerate this diff without the whitespace changes.  It is
completely unreadable in the current form.

Examples:

> -  engine_class context_class request_class response_class stats_class 
> +  engine_class context_class request_class response_class stats_class

> -    
> +

> -        $c->stash->{data} = 
> +        $c->stash->{data} =

These spurious changes fuck up the history (when we apply the patch),
and they make it extremely difficult to review your changes.

GNU diff accepts an "--ignore-space-change" option that should remove
these extra changes.

Regards,
Jonathan Rockway

-- 
print just => another => perl => hacker => if $,=$"

_______________________________________________
List: Catalyst@lists.scsys.co.uk
Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/
Dev site: http://dev.catalyst.perl.org/

Reply via email to