Here is the very simplistic patch, which only renames the "actions"
attribute to "_controller_actions" in Catalyst::Controller. Test suite still
passes with the patch and my app that originally showed that error, is now
also working like a charm.
Cheers
+rl
On Tue, May 12, 2009 at 00:07, Roland Lammel <[email protected]>wrote:
> Ok, I'll do a patch renaming it to "_controller_actions" that *should* be
> sensible enough to not clash in the future.
>
> +rl
>
>
> On Mon, May 11, 2009 at 19:22, Hans Dieter Pearcey <
> [email protected]> wrote:
>
>> On Mon, May 11, 2009 at 06:13:19PM +0100, Matt S Trout wrote:
>> > That's a bug, the attribute should -not- be called 'actions'.
>>
>> Or, at least, its accessor shouldn't. (Naming the attribute itself
>> 'actions'
>> vs. '_actions' is a matter of taste.)
>>
>> hdp.
>>
>> _______________________________________________
>> List: [email protected]
>> Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
>> Searchable archive:
>> http://www.mail-archive.com/[email protected]/
>> Dev site: http://dev.catalyst.perl.org/
>>
>
>
>
> --
> Roland Lammel
> QuikIT - IT Lösungen - flexibel und schnell
> Web: http://www.quikit.at
> Email: [email protected]
>
> "Enjoy your job, make lots of money, work within the law. Choose any two."
>
--
Roland Lammel
QuikIT - IT Lösungen - flexibel und schnell
Web: http://www.quikit.at
Email: [email protected]
"Enjoy your job, make lots of money, work within the law. Choose any two."
diff -u -r Catalyst-Runtime-5.80003/lib/Catalyst/Controller.pm Catalyst-Runtime-5.80003-fix-actions-keyword/lib/Catalyst/Controller.pm
--- Catalyst-Runtime-5.80003/lib/Catalyst/Controller.pm 2009-04-27 14:22:54.000000000 +0200
+++ Catalyst-Runtime-5.80003-fix-actions-keyword/lib/Catalyst/Controller.pm 2009-05-12 00:18:37.000000000 +0200
@@ -29,7 +29,7 @@
predicate => 'has_action_namespace',
);
-has actions =>
+has _controller_actions =>
(
is => 'rw',
isa => 'HashRef',
@@ -41,7 +41,7 @@
my $action = delete $args->{action} || {};
my $actions = delete $args->{actions} || {};
my $attr_value = $self->merge_config_hashes($actions, $action);
- $self->actions($attr_value);
+ $self->_controller_actions($attr_value);
}
=head1 NAME
@@ -260,7 +260,7 @@
# superior while mantaining really high degree of compat
my $actions;
if( ref($self) ) {
- $actions = $self->actions;
+ $actions = $self->_controller_actions;
} else {
my $cfg = $self->config;
$actions = $self->merge_config_hashes($cfg->{actions}, $cfg->{action});
_______________________________________________
List: [email protected]
Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/[email protected]/
Dev site: http://dev.catalyst.perl.org/
