I think a patch that made sure strings being set to location conformed to the expected standard would be very welcomed!
on the other hand I thought this was also caught by https://metacpan.org/pod/Plack::Middleware::Lint as well? In any case Catalyst response could reject any attempts to set ->location with incorrect values. The only thing is that people could still probably get around it by setting headers directly. I think for now we'll say if you do that we have to assume you know what you are doing! John On Thursday, October 31, 2013 7:03 PM, Bill Moseley <mose...@hank.org> wrote: On Thu, Oct 31, 2013 at 2:34 PM, John Napiorkowski <jjn1...@yahoo.com> wrote: I'm currently recommending people take advantage of native PSGI support in the newer Catalyst and use Middleware for when you need to munge and or alter the response (if its being done globally). The interface is more straightforward. Do you think that Catalyst::Response should validate the location provided to redirect()? The issue that came up was a newline was ending up in the location provided which resulted in a split response. I was thinking of doing something like: $self->location( URI->new( $location )->as_string ); But with perhaps a bit more error handling. > >johnn > > > >On Thursday, October 31, 2013 11:33 AM, Bill Moseley <mose...@hank.org> wrote: > > > >On Thu, Oct 31, 2013 at 12:51 AM, Aristotle Pagaltzis <pagalt...@gmx.de> wrote: > >CatalystX::RoleApplicator >Thanks. That was what I was looking for. Just missed it when looking. > > > >-- >Bill Moseley >mose...@hank.org > >_______________________________________________ >List: Catalyst@lists.scsys.co.uk >Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst >Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/ >Dev site: http://dev.catalyst.perl.org/ > > > >_______________________________________________ >List: Catalyst@lists.scsys.co.uk >Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst >Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/ >Dev site: http://dev.catalyst.perl.org/ > > > -- Bill Moseley mose...@hank.org
_______________________________________________ List: Catalyst@lists.scsys.co.uk Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/ Dev site: http://dev.catalyst.perl.org/
