I'm hesitant to commit the changes to xdgmime. This code has been pulled from http://webcvs.freedesktop.org/mime/xdgmime/src/. The two should really be in sync so that we can easily take advantage of changes upstream. It would be best to get these changes into the freedesktop.org cvs and then sync the two.
How about I commit everything else and hold off on treating warnings as failures? Otherwise, looks great, and I should be able to commit this (and the other patches) Monday. Thanks! Jason > Patches item #1781904, was opened at 2007-08-25 20:04 > Message generated for change (Comment added) made by kidproto > You can respond by visiting: > https://sourceforge.net/tracker/?func=detail&atid=559968&aid=1781904&group_id=80503 > > Please note that this message will contain a full copy of the comment thread, > including the initial issue submission, for this request, > not just the latest update. > Category: None > Group: None > Status: Open > Resolution: None > >> Priority: 7 >> > Private: No > Submitted By: Peter Miller (pmiller) > >> Assigned to: Jason Kivlighn (jakin44) >> > Summary: liblicense.0.4 - fix compiler warnings > > Initial Comment: > This change set fixes a number of compiler warnings. The only controversial > part is the addition of -Werror to CFLAGS to prevent the reintroduction of > code with warnings. > > ---------------------------------------------------------------------- > > >> Comment By: Jon Phillips (kidproto) >> > Date: 2007-08-25 21:31 > > Message: > Logged In: YES > user_id=914868 > Originator: NO > > I think that is a good addition....please keep them coming? You want to be > added to the project so you can commit freely? > > ---------------------------------------------------------------------- > > You can respond by visiting: > https://sourceforge.net/tracker/?func=detail&atid=559968&aid=1781904&group_id=80503 > > _______________________________________________ cc-devel mailing list [email protected] http://lists.ibiblio.org/mailman/listinfo/cc-devel
