On Wed, Jun 23, 2010 at 1:05 PM, Joel Rosdahl <j...@rosdahl.net> wrote:
> Hi, > > On 2010-06-22 02:31, Reuben Hawkins wrote: > > I made some modification to the build system... > > > > * added info from autoscan to configure.ac <http://configure.ac> > > * added a Makefile.am so automake can generate Makefile.in > > * moved test.sh to test/test.sh for make check (for adding more tests > > later and keeping them together) > > Unfortunately, I have never been an Automake fan, so you will have to > try hard to convince me that there's any net gain in introducing > Automake. (I'm not an Autoconf fan either, by the way, so I'd rather > look at waf or cmake if I wanted to improve things, but for such a > simple project as ccache, Autoconf feels OK.) > > Before: > > % time make >/dev/null > make > /dev/null 0.09s user 0.05s system 86% cpu 0.161 total > > After: > > % time make >/dev/null > In file included from hashtable.h:35, > from ccache.c:24: > config.h:261:1: warning: "_POSIX_C_SOURCE" redefined > In file included from /usr/include/inttypes.h:26, > from mdfour.h:5, > from ccache.h:5, > from ccache.c:22: > /usr/include/features.h:158:1: warning: this is the location of the > previous definition > In file included from hashtable.h:35, > from ccache.c:24: > config.h:274:1: warning: "_XOPEN_SOURCE" redefined > In file included from /usr/include/inttypes.h:26, > from mdfour.h:5, > from ccache.h:5, > from ccache.c:22: > /usr/include/features.h:160:1: warning: this is the location of the > previous definition > In file included from hashtable.h:35, > from hashtable_itr.h:5, > from manifest.c:20: > config.h:261:1: warning: "_POSIX_C_SOURCE" redefined > In file included from /usr/include/inttypes.h:26, > from mdfour.h:5, > from ccache.h:5, > from manifest.c:19: > /usr/include/features.h:158:1: warning: this is the location of the > previous definition > In file included from hashtable.h:35, > from hashtable_itr.h:5, > from manifest.c:20: > config.h:274:1: warning: "_XOPEN_SOURCE" redefined > In file included from /usr/include/inttypes.h:26, > from mdfour.h:5, > from ccache.h:5, > from manifest.c:19: > /usr/include/features.h:160:1: warning: this is the location of the > previous definition > make > /dev/null 0.20s user 0.17s system 100% cpu 0.369 total > > In my perspective, Automake makes things slower and more complex with > little or no gain. Sorry. Perhaps I'm missing something? > > > These changes fixed ccache -V showing "unknown" for me as well as > > simplify the build (using automake, etc). > > The version was hardcoded previously, but I recently improved it to use > "git describe", which makes the version string include information about > which tree was built (the distance to the nearest tag and the hash). > Example for the revision before the one that become 3.0: > > % ./ccache -V | head -1 > ccache version 3.0pre1+115_g29a91e1 > > I.e., 115 commits has been made after the v3.0pre1 tag and the hash of > the tree is 29a91e1. My hope is that this will improve bug reports and > communication when people are building from the Git tree. > > If your version become "unknown", then I guess you neither built an > official release nor from a Git tree? > Built from the git tree. $ ./autogen.sh $ ./configure-dev $ make It seems the cause of the problem for me is... `(git describe --dirty 2>/dev/null || echo vunknown) | sed -e 's/v//' -e 's/-/+/' -e 's/-/_/g'` return "unknown" becuase $ echo `git describe --dirty` fatal: No names found, cannot describe anything. My git version is $ git --version git version 1.7.0.4 and I'm on commit: 11ec900409648b0879e473928e86e6679304597d I'd look into it more, but I'm out of town for a few days... > Regards, > Joel > _______________________________________________ ccache mailing list ccache@lists.samba.org https://lists.samba.org/mailman/listinfo/ccache