On 2010-07-15 22:07, Ramiro Polla wrote: > I updated the fork at http://github.com/ramiropolla/ccache > > I also went through all the issues from other forks from > http://code.google.com/p/ccache-win32/ and > http://gitorious.org/ccache-win and fixed them.
Splendid! "Run stat() before open() on some files to allow bailing out earlier": Applied. "Include getopt.h when getopt_long() is provided by the system": Applied. "Unlink destination file before renames": Applied with commit message tweak. "Introduce and use x_fmmap() and x_munmap()": Applied with commit message tweak. "Close file opened with gzdopen()": Applied. "Duplicate path string inside find_executable_in_path() instead of expecting caller to duplicate it before.": Applied with commit message tweak. "Close manifest files after reading/writing them": Applied. "Implement is_absolute_path() helper function.": Applied with commit message tweak. "Implement compare_executable_name() helper function.": Applied with commit message tweak. "Implement is_full_path() helper function": This doesn't work if the path is "../foo" or any other relative path other than "./foo". Doesn't just searching for "/" or "\\" work on Windows too? "Clear exit_functions after the exit functions have been called": Applied. "Add a define for path delimiter": Applied. Also made CCACHE_EXTRAFILES use PATH_DELIM. "Use a temporary file for sed_in_place()": Applied. "Allow testsuite to run on Windows": Applied. "Win32 support": In compare_executable_name, you can use x_asprintf(&tmp, "%s.exe", s2) instead. Otherwise, looks good to me. -- Joel _______________________________________________ ccache mailing list email@example.com https://lists.samba.org/mailman/listinfo/ccache