On Sun, Sep 18, 2016 at 06:52:04PM -0600, Kevin Locke wrote:
> Visual Studio prints warning C4706 "assignment within conditional
> expression" when there is an assignment without a comparison in a
> conditional expression.  Therefore, to silence the warning, add an
> explicit comparison.
> 
> Signed-off-by: Kevin Locke <ke...@kevinlocke.name>

Signed-off-by: David Gibson <da...@gibson.dropbear.id.au>

> ---
>  tools/configurator/configurator.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/configurator/configurator.c 
> b/tools/configurator/configurator.c
> index 0386930..0c30aff 100644
> --- a/tools/configurator/configurator.c
> +++ b/tools/configurator/configurator.c
> @@ -535,7 +535,7 @@ static bool run_test(const char *cmd, struct test *test)
>               char *dep;
>  
>               /* Space-separated dependencies, could be ! for inverse. */
> -             while ((len = strcspn(deps, " "))) {
> +             while ((len = strcspn(deps, " ")) != 0) {
>                       bool positive = true;
>                       if (deps[len]) {
>                               dep = strdup(deps);

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

Attachment: signature.asc
Description: PGP signature

_______________________________________________
ccan mailing list
ccan@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/ccan

Reply via email to