Hi Alex
the patches are ok, my bad, sorry The view in FF was strange when they have the .patch extention. But when I download the file, and open them with notepad, all is ok. So do not worry about this ;-) with kind regards Ruben Willems On Thu, Oct 9, 2008 at 2:15 PM, Alex <[EMAIL PROTECTED]> wrote: > > Actually Rueben, I just examined the patches for both of those and > when I donwloaded them and opened them in a text editor, they were > both correct. Daniel told me to be in the directory of the change and > issue the command svn diff > filename.patch, is that correct? > > On Oct 9, 8:00 am, Alex <[EMAIL PROTECTED]> wrote: > > Will do Rueben > > > > On Oct 9, 2:46 am, "Ruben Willems" <[EMAIL PROTECTED]> wrote: > > > > > > > > > Hi Alex > > > > > It's better to send stuf like this to the devel list, > > > not all developers read the user list on a daily basis. > > > > > Your patch for ccnet 1267 and 1270 appears to be something binary, > > > can you re-post them on Jira? > > > > > You patch for ccnet-1268 is readable as text, so there must went > something > > > wrong on > > > creating these 2 patches > > > > > wiht kind regards > > > Ruben Willems > > > > > On Mon, Oct 6, 2008 at 1:42 PM, Alex <[EMAIL PROTECTED]> wrote: > > > > > > So I had time to look at this last week, it turns out that Mono on > the > > > > Mac had an issue not being able to accurately reflect the WaitForExit > > > > and HasExited values. This was causing CC.NET to run out of threads. > > > > However, while chasing this I spent a lot of time refactoring the > > > > ProcessExecutor class and getting rid of the ProcessReader class as > it > > > > is a waste of resources and complexity. Instead of spawning another > > > > thread to handle the ouput for standardoutput and standarderror. I > now > > > > just use the intended event handler and let the object take care of > it > > > > itself. I will be submitting a patch on JIRA later today as I think > > > > this is a better implementation and removes useless code. I also > fixed > > > > KillUtil's Kill process which would not actually work on OSX and will > > > > submit the patch for that aas well. The Mono team though has their > > > > issues fixed in 2.0, I am running the RC but the final is due out > this > > > > week, so if you are planning on running CC.NET on a mac make sure > you > > > > are using 2.0 and you should be golden.- Hide quoted text - > > > > > - Show quoted text -- Hide quoted text - > > > > - Show quoted text - >
