This could just be me miss-understanding how the pre-processor is
working... but here's what I think I am doing ;-)

re: group="$(Group)"
------------------------------
First I define a user as:

  <cb:define name="User1">
        <user name="User1" group="$(Group)"
address="[email protected]"/>
  </cb:define>

$(Group) is a parameter I can pass into the defined macro. Then I use
the user like so:

<cb:User1 group="$(MAILGROUP_BUILDMASTER)"/>

I am expecting "MAILGROUP_BUILDMASTER", previously defined as
"Buildmaster" to be passed into the macro and substituted with $
(Group) giving the end result:

        <user name="User1" group="Buildmaster"
address="[email protected]"/>

re: I only see a MAILGROUP_BUILDMASTER definition
--------------------------------------------------------------------------------
Right at the top is a block of basic defines.

  <cb:define
        MAILHOST="mail.ourcompany.com"
        MAILSOURCE="[email protected]"

        MAILGROUP_DEVELOPERS="Developers"
        MAILGROUP_BUILDMASTER="BuildMaster"
  />

A define is created here for Developers and Build Masters.

For convienience MAILGROUPS defines teh group settings, here I say
that the group MAILGROUP_BUILDMASTER, ie. "Buildmaster" is set to be
notified "always"

  <cb:define name="MAILGROUPS">
        <groups>
                <group name="$(MAILGROUP_BUILDMASTER)"
notification="always"/>
        </groups>
  </cb:define>

Since I don't want any group wide settings for "developers" I have
left them out.

Then in my email block is used like so (it just provides a short-hand
version):

<cb:MAILGROUPS/>

This is instead of cut and pasting a <Group> block for every email
publisher I have (there are many:).




Perhaps I should just ditch the pre-processor and do everything long
hand?

Cheers,
Shaun


On 25 Feb, 12:27, Ruben Willems <[email protected]> wrote:
> Hi
>
> what is the definition for the following?
> group="$(Group)"
>
> I only see a MAILGROUP_BUILDMASTER definition
> did you omit it from the example?
>
> you seem to place users in "$(Group)"
> but this is not defined in the groups section
>
> with kind regards
> Ruben Willems
>
> On Wed, Feb 25, 2009 at 1:20 PM, CinnamonDonkey <
>
> [email protected]> wrote:
>
> > <cruisecontrol xmlns:cb="urn:ccnet.config.builder">
> >  <cb:define
> >        MAILHOST="mail.ourcompany.com"
> >        MAILSOURCE="[email protected]"
>
> >        MAILGROUP_DEVELOPERS="Developers"
> >        MAILGROUP_BUILDMASTER="BuildMaster"
> >  />
>
> >  <cb:define name="MAILGROUPS">
> >        <groups>
> >                <group name="$(MAILGROUP_BUILDMASTER)"
> > notification="always"/>
> >        </groups>
> >  </cb:define>
>
> >  <cb:define name="User1">
> >        <user name="User1" group="$(Group)"
> > address="[email protected]"/>
> >  </cb:define>
>
> >  <cb:define name="User2">
> >        <user name="User2" group="$(Group)"
> > address="[email protected]"/>
> >  </cb:define>
>
> >  <project name="AProject" queue="AProject">
> >        .
> >        .
> >        .
> >        <publishers>
> >          <email from="$(MAILSOURCE)" mailhost="$(MAILHOST)"
> > includeDetails="TRUE">
> >                 <users>
> >                      <cb:User1 group="$(MAILGROUP_BUILDMASTER)"/>
> >                      <cb:User2 group="$(MAILGROUP_DEVELOPERS)"/>
> >                 </users>
>
> >                 <cb:MAILGROUPS/>
>
> >                 <modifierNotificationTypes>
> >                      <NotificationType>Fail</NotificationType>
> >                 </modifierNotificationTypes>
> >           </email>
> >       </publishers>
> >  </project>
> > </cruisecontrol>
>
> > What I would expect from this is:
>
> > - Build Masters get emailed always regardless of completion state for
> > every build
> > - Only the users listed as modifiers receive emails and only on fail.
>
> > What we seem to get is everyone gets emailed on a failed build.
>
> > On 25 Feb, 11:25, Ruben Willems <[email protected]> wrote:
> > > Hi
>
> > > not to my knowledge.
> > > can you post your email config
> > > passwords and usernames may be replaced by JohnDoe's ;-)
>
> > > with kind regard
> > > Ruben Willems
>
> > > On Wed, Feb 25, 2009 at 12:17 PM, CinnamonDonkey <
>
> > > [email protected]> wrote:
>
> > > > Is it default dehaviour that a Failed build wil always emails ALL
> > > > developers?
>
> > > > On 24 Feb, 08:01, CinnamonDonkey <[email protected]>
> > > > wrote:
> > > > > Hi Helmut,
>
> > > > > Thanx for the reply... I'm ashamed to say, I was too busy doing all
> > > > > the other fun stuff to pay attention to the difference between
> > > > > <groups> and <modifierNotificationTypes>.
>
> > > > > Now that I've re-read and undestood the publisher docs I have
> > realised
> > > > > what I have been doing wrong... <b>Doh!</b>.
>
> > > > > Hopefully this will be the end of my emailer issues... we will see
> > :-)
>
> > > > > Cheers,
> > > > > Shaun <8)
>
> > > > > The other option is <modifierNotificationTypes>, this is the
> > condition
> > > > > under which the change list owner (modifier) will be notified of the
> > > > > results of the build.
> > > > > On 19 Feb, 13:52, Helmut <[email protected]> wrote:
>
> > > > > > What is you email setup?  Did you setup groups?  We are using the
> > > > > > following and it seems to work as advertised:
>
> > > > > >         <users>
> > > > > >           <user name='harrold' group='buildmaster'
> > > > > > address='[email protected]'/>
> > > > > >           <user name='bill' group='buildmaster'
> > > > > > address='[email protected]'/>
> > > > > >           <user name='ray' group='buildmaster'
> > > > > > address='[email protected]'/>
> > > > > >         </users>
> > > > > >         <groups>
> > > > > >           <group name='developers' notification='change'/>
> > > > > >           <group name='buildmaster' notification='always'/>
> > > > > >         </groups>
> > > > > >           <converters>
> > > > > >                 <regexConverter find= '$' replace= '...@
> > > > edfinancial.com' />
> > > > > >           </converters>
> > > > > >           <modifierNotificationTypes>
> > > > > >                 <NotificationType>Failed</NotificationType>
> > > > > >           </modifierNotificationTypes>
>
> > > > > > buildmaster -always, developer - on change, build failure - last
> > > > > > person to modify code
> > > > > > On Feb 9, 6:01 am, CinnamonDonkey <[email protected]>
> > > > > > wrote:
>
> > > > > > > Hi All,
>
> > > > > > > This may be a known issue with version 1.4.1, but the email
> > publisher
> > > > > > > seems to email evryone sometimes... for example, this happened
> > over
> > > > > > > the weekend:
>
> > > > > > >    > build failed -> everyone emailed
> > > > > > >    > build fixed/success -> everyone emailed
> > > > > > >    > build failed -> correctly emailed changelist owner
> > > > > > >    > build fixed/success -> correctly emailed changelist owner.
>
> > > > > > > I can't see any particular reason why everyone was emailed,
> > unless it
> > > > > > > didn't know who the change list owner was for some reason?
>
> > > > > > > Has anyone else experienced this?
>
> > > > > > > Regards,
> > > > > > > Shaun

Reply via email to