Yes, it does seem tricky.  You can't just re-check the triggers before
querying source control because, for example, you'd reset the
intervalTrigger's timer, or you'd re-query a project's status in the
projectTrigger (and possibly change the reason the project was queued
up in the first place).  It's like you should *only* re-check the
filterTriggers, but that doesn't seem like an easy task.  If the check
fails (after already being on the queue), what do you do?  Re-queue
it?  Or just remove it?

Anyways, thanks Craig.

-- Adam

On Apr 13, 2:57 pm, "Craig & Sammi Sutherland"
<[email protected]> wrote:
> You are completely correct in your summation of how things work. And you
> have also identified a problem with the process.
>
> I have raised this as an issue in 
> JIRA:http://jira.public.thoughtworks.org/browse/CCNET-1458. It looks like a
> tricky one to fix, so I can't give you a timeline on when it will be
> resolved.
>
> Craig
>
> -----Original Message-----
> From: [email protected] [mailto:[email protected]] On
>
> Behalf Of adickinson
> Sent: Tuesday, 14 April 2009 6:14 a.m.
> To: ccnet-user
> Subject: [ccnet-user] Problem with Triggers (related to filterTrigger)
>
> I'm having a problem with the behavior of the triggers.  I'm using
> source control and a build queue.
>
> Correct me if I'm wrong, but the way they seems to work is this:
> 1) Check the triggers.  If the condition(s) pass, add to the queue.
> 2) Once a project gets to the top of the queue, check source control
> for changes.  If changes are found, build it.
>
> Here's the problem I'm having:
>
> My builds take anywhere from 5 minutes to 3 hours (just depends on how
> much code was checked in) and I have several of them on each server.
> A project can get on the queue hours before it checks source control
> for changes.  We perform maintenance on our source control server
> every night at 11:30.  In order to prevent the build from ever
> occurring during our maintenance, I would have to set my filterTrigger
> to 8:30pm or earlier, which just seems ridiculous.
>
> Shouldn't the filterTrigger apply to the when the source control check
> is made as well?

Reply via email to