Hello, i've implemented the last missing feature on my todo list:
* add during the build process created files to the git index before commit & tagging * commit during the build process modified files before tagging Both options are disabled by default. Everything is documented here: [1] I've closed CCNET-1554, if you find bugs or any other issues please create a new JIRA issue. Testing and feedback is welcome ;) Thanks Daniel [1] http://confluence.public.thoughtworks.org/display/CCNET/Git+Source+Control+Block Daniel Nauck schrieb: > Hi Kevin > > thanks for your feedback. I've fixed all the outstanding issues. Thanks > for reviewing the code. > > For testing purpose i'm monitoring the RubyOnRails master branch for 2 > weeks now. I had no issue until now. > > One missing feature is to commit local changes before push the tag in > the "tagOnSuccess" mode. > I'll work on this in the next days. > > > Do you found time to test an up2date 1.5 version in "real-life" ? > > Daniel > > Kevin Read schrieb: > >> Daniel, >> >> Let me start by saying excellent work! It looks to me like a huge >> improvement over the plugin I put together. >> >> I downloaded CruiseControl.NET-1.5.0.4364.source and took a quick look >> through Git.cs and GitHistoryParser.cs, my comments below. I haven't >> actually setup a 1.5 ccnet server yet, just looking at your code for >> now. >> >> In the SetupLocalRepository routine, the variables user.name and >> user.email are set. If these are not provided, a warning message is >> generated because they are needed for the TagOnSuccess feature. In >> our scenario we set these git variables at a git global scope, so the >> tagging will still work and the warning message is a bit misleading. >> I think it would be better to check git for the variables (git config >> --list) before displaying any warning saying they are "missing". >> >> git.cs Indentation was a little all over the place, don't know if you >> even care about this >> git.cs:123 Grammar mistake in the comment >> git.cs:128 Spelling mistake in the comment >> git.cs:142 Grammar mistake in the message >> >> I couldn't get to >> http://confluence.public.thoughtworks.org/display/CCNET/Git+Source+Control+Block >> to view the documentation. Probably something my end thou, will try >> again later to check it out. >> >> I'm going to install 1.5 on a test server to give the plugin a run. >> If you going to make further changes based on the comments above then >> I'll hold off until your done. >> >> Cheers, >> >> Kevin >> >> p.s. I dropped [email protected] from the cc list, didn't >> think they would care too much about this. >> >> 2009/6/19 Daniel Nauck <[email protected]>: >> >> >>> Hello, >>> >>> i've updated the documentation about the Git Source Control Block[1] in >>> the wiki. >>> >>> if you want to test Git + CruiseContro.NET, you can download the latest >>> build available on CCNetLive[2]. >>> I'll be happy about some feedback. >>> >>> Daniel >>> >>> [1] >>> http://confluence.public.thoughtworks.org/display/CCNET/Git+Source+Control+Block >>> [2] http://ccnetlive.thoughtworks.com/CCNet-builds/1.5.0/ >>> >>> Daniel Nauck schrieb: >>> >>> >>>> Hello, >>>> >>>> the Git source control block does now support modifications on a per >>>> file basis and also set the commit hash as "LastChangeNumber". >>>> It still need a lot of testing. >>>> >>>> Daniel >>>> >>>> Daniel Nauck schrieb: >>>> >>>> >>>> >>>>> Hello, >>>>> >>>>> i comitted the initial version of the Git source control support into >>>>> CruiseControl.NET 1.5 trunk. >>>>> >>>>> Kudos to Kevin Read. The patch is based on a ccnet plugin from him. >>>>> >>>>> There're some open issues: >>>>> >>>>> - getting the sha1 hash of the last commit and set "LastChangeNumber" >>>>> - getting all required modification information >>>>> - find and fix bugs >>>>> >>>>> >>>>> We'll work on these issues soon. >>>>> >>>>> Daniel >>>>> >>>>> >>>>> >>>>>
